Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[evcc] Fix unit hints missing for percentage channels #17294

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Aug 19, 2024

Fixes: #17177

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Aug 19, 2024
@lsiepel lsiepel requested a review from florian-h05 as a code owner August 19, 2024 12:35
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jlaur jlaur changed the title [evcc] Fix unithints missing for percentage channels. [evcc] Fix unit hints missing for percentage channels Aug 19, 2024
@lsiepel lsiepel removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Aug 24, 2024
@florian-h05
Copy link
Contributor

@openhab/add-ons-maintainers Can you please merge?

@kaikreuzer kaikreuzer merged commit f5eb2c6 into openhab:main Aug 26, 2024
5 checks passed
@kaikreuzer kaikreuzer added this to the 4.3 milestone Aug 26, 2024
@lsiepel lsiepel deleted the evcc-unithint branch August 26, 2024 16:22
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[evcc] Wrong Data in percentage values
4 participants