Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modbus] Support chaining transformations without an intersection symbol #17306

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Aug 21, 2024

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from ssalonen as a code owner August 21, 2024 13:13
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/syntax-for-binding-transformations/157861/1

@jimtng jimtng marked this pull request as draft August 21, 2024 13:19
@jimtng jimtng added the awaiting other PR Depends on another PR label Aug 21, 2024
@jimtng jimtng changed the title [modbus] Refactor to use ChannelTransformation [modbus] Support chaining transformations without an intersection symbol Aug 21, 2024
@jimtng jimtng added the enhancement An enhancement or new feature for an existing add-on label Aug 21, 2024
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng marked this pull request as ready for review August 30, 2024 16:50
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng removed the awaiting other PR Depends on another PR label Aug 31, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit ff2f190 into openhab:main Sep 6, 2024
5 checks passed
@jimtng jimtng deleted the modbus-transform branch September 6, 2024 14:46
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Sep 24, 2024
…bol (openhab#17306)

* [modbus] Refactor to use ChannelTransformation

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng
Copy link
Contributor Author

jimtng commented Sep 25, 2024

@lsiepel should we add the 4.3 milestone on this?

@lsiepel lsiepel added this to the 4.3 milestone Sep 25, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Sep 25, 2024

@lsiepel should we add the 4.3 milestone on this?

Yes, thanks for the heads up

pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
…bol (openhab#17306)

* [modbus] Refactor to use ChannelTransformation

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
…bol (openhab#17306)

* [modbus] Refactor to use ChannelTransformation

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
…bol (openhab#17306)

* [modbus] Refactor to use ChannelTransformation

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants