[ChatGPT] Enhance binding

[Artur-Fedjukevits]

This is a new PR because the old one was broken due to incorrect rebase. I hope I have taken all the comments into account. @lsiepel and @kaikreuzer welcome to the review.

[Artur-Fedjukevits]

Here is jar for testing.

[Artur-Fedjukevits]

I'm a Git noob. I tried to open a new PR with another addon. How can I create a new PR that does not include already existing commits in my fork? I have a new commit in the new branch, but when I try to open a PR, it includes all commits from this PR...

[kaikreuzer]

@Artur-Fedjukevits You should always use feature branches and never work on main.
You can have a branch per PR, so that you can work on them independently. Check out something like https://www.split.io/blog/understanding-the-feature-branching-strategy-in-git/ if this is new to you. 😄

[kaikreuzer]

I think to remember that you said that this parameter is obsolete and can be removed?

[Artur-Fedjukevits]

No, I didn't. I was talking about another parameter that has already been removed. I find the 'Top P' parameter useful.

[kaikreuzer]

... but I am talking about the "type" parameter here.

[Artur-Fedjukevits]

@Artur-Fedjukevits You should always use feature branches and never work on main. You can have a branch per PR, so that you can work on them independently. Check out something like https://www.split.io/blog/understanding-the-feature-branching-strategy-in-git/ if this is new to you. 😄

Thanks. Yes, it's new to me. Everything in this field is new to me, I’m still learning. :) From now on, I'll do it.

[Artur-Fedjukevits]

Hi @kaikreuzer. Do you have time for review this PR?

[kaikreuzer]

Still on my list, sorry for taking so long - it is not forgotten!

[ThaDaVos]

Question out of curiosity - but is this based on the Assistants API/Functionality of OpenAI?
https://platform.openai.com/docs/assistants/overview

[Artur-Fedjukevits]

Question out of curiosity - but is this based on the Assistants API/Functionality of OpenAI? https://platform.openai.com/docs/assistants/overview

It based on function calling via Chat Completions API

[kaikreuzer]

Thanks - I did a round of code review first, without actively testing the functionality yet. Please find my comments below.

[kaikreuzer]

... but I am talking about the "type" parameter here.

[ThaDaVos]

Question out of curiosity - but is this based on the Assistants API/Functionality of OpenAI? https://platform.openai.com/docs/assistants/overview

It based on function calling via Chat Completions API

Ah, I myself was looking in the Assistents API (Which also supports Function Calling) as it seemed to be more fitting for controlling a home-automation system

Also @kaikreuzer - kudo's on the reviewing, it's so concise and descriptive! Amazing!

[Artur-Fedjukevits]

Thanks @kaikreuzer!

I hope I’ve taken all your comments into account and fixed everything. I’m looking forward to your next comments :)
I'm sorry for making so many mistakes :(

[florian-h05]

@Artur-Fedjukevits Many thanks for this awesome PR - I have just started playing around with it a bit and what I have seen so far looks promising. LLMs bring human language interpretation to a whole new level 🚀
Just FYI: This binding also works with Ollama's REST API, so I can play around with it offline on my laptop with a Llama 3.2 3B.

[lsiepel]

@Artur-Fedjukevits can you fix the merge conflict for the readme?

[kaikreuzer]

Thanks for addressing my comments. A few small things are still open, see my comments below.

[kaikreuzer]

Suggested change

	String LivingRoom_AC_Mode "Thermostat mode in the living room" [ "OpenAI" ] {channel="", am="OFF, HEAT, AUTO, COOL, FAN, DRY" }
	String LivingRoom_AC_Mode "Thermostat mode in the living room" [ "OpenAI" ] {am="OFF, HEAT, AUTO, COOL, FAN, DRY" }

[kaikreuzer]

Sorry, I still don't understand what the "am" metadata namespace is about. What you need here are simply command options, which is already possible to set in the Main UI for your items (and it should be possible to add them textually with the "commandDescription" namespace as well).
The nice thing is that these options are already provided from bindings for certain channels, so the users might not even have to define it themselves.

[Artur-Fedjukevits]

I'm not using the main UI at all; everything is in files, and I have never heard of the 'commandDescription' namespace either. I will then rewrite this part.

[Artur-Fedjukevits]

Fixed. Should I describe this in the README, or does it go without saying? Something like: "If your item accepts special commands and they are not provided by the binding, you need to set them in the main UI or add the 'commandDescription' namespace to the item."

[florian-h05]

I would write:

„An Item’s command options are used to determine available commands. If your Item accepts special commands, but the binding does not provide command options, you can use the command description metadata.“

[Artur-Fedjukevits]

@Artur-Fedjukevits can you fix the merge conflict for the readme?

fixed

[kaikreuzer]

Thanks @Artur-Fedjukevits for your updates and your patience with the review process. I think the result is great and we are good to merge!
Just one last tiny change request where the code does not yet meet the documentation.

[kaikreuzer]

I've done the small change myself, so that it can be merged and included in tomorrow's milestone.

[Artur-Fedjukevits]

Nice! Thanks!