Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rollershutterposition] Fix parameter configuration through UI #17341

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

jsjames
Copy link
Contributor

@jsjames jsjames commented Aug 27, 2024

This pull request fixes the uri in the .xml config file to match other transform profiles. This addresses the bug #17340 where the parameters cannot be configured via the main ui.

Signed-off-by: Jeff James <jeff@james-online.com>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jlaur jlaur changed the title [rollershutterposition] fixed xml uri ID [rollershutterposition] Fix parameter configuration through UI Aug 27, 2024
@jlaur jlaur merged commit 8725dcb into openhab:main Aug 27, 2024
5 checks passed
@jlaur jlaur added this to the 4.3 milestone Aug 27, 2024
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Aug 27, 2024
jlaur pushed a commit that referenced this pull request Aug 27, 2024
Signed-off-by: Jeff James <jeff@james-online.com>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Aug 27, 2024
@jsjames jsjames deleted the rollershutter branch August 27, 2024 19:41
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
Signed-off-by: Jeff James <jeff@james-online.com>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/greenhouse-vents-linear-actuator-control-rules/158106/7

pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: Jeff James <jeff@james-online.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Jeff James <jeff@james-online.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Jeff James <jeff@james-online.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rollershutterposition] Configuration parameters are not listed in the main UI.
3 participants