[Tibber] Improve connection logic #17344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsiepel
requested changes
Aug 28, 2024
....binding.tibber/src/main/java/org/openhab/binding/tibber/internal/handler/TibberHandler.java
Outdated
Show resolved
Hide resolved
....binding.tibber/src/main/java/org/openhab/binding/tibber/internal/handler/TibberHandler.java
Outdated
Show resolved
Hide resolved
....binding.tibber/src/main/java/org/openhab/binding/tibber/internal/handler/TibberHandler.java
Outdated
Show resolved
Hide resolved
lsiepel
added
rebuild
lsiepel
changed the title
lsiepel
approved these changes
Aug 28, 2024
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Aug 29, 2024
* Fixes openhab#14735 Optimized Logging and sending Ping Frames. See also PR openhab#17214 Signed-off-by: christian <dev@bestof5.de>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
* Fixes openhab#14735 Optimized Logging and sending Ping Frames. See also PR openhab#17214 Signed-off-by: christian <dev@bestof5.de> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
* Fixes openhab#14735 Optimized Logging and sending Ping Frames. See also PR openhab#17214 Signed-off-by: christian <dev@bestof5.de>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
* Fixes openhab#14735 Optimized Logging and sending Ping Frames. See also PR openhab#17214 Signed-off-by: christian <dev@bestof5.de>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
* Fixes openhab#14735 Optimized Logging and sending Ping Frames. See also PR openhab#17214 Signed-off-by: christian <dev@bestof5.de> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull request for PR #17214
After changing the Log Level to Debug I was not able to see something in the logs. Also a Thread Dump could not give me a hint to the error.
So it is not a real fix, but the WebSocket should be reconnect after the Tibber WebSocket connection received no data for 5 minutes.
Fixes #14735