Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pushover] Fix idle connection causing EOF exception #17348

Merged
merged 15 commits into from
Oct 7, 2024

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Aug 29, 2024

Fixes: #10376 by adding a custom httpclient with a shorter timeout.

Could be backported to 4.2.x

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Aug 29, 2024
@lsiepel lsiepel requested a review from a team August 29, 2024 15:16
@lsiepel lsiepel requested a review from cweitkamp as a code owner August 29, 2024 15:16
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this long-awaited fix! 🙂 I have only one comment in three separate parts for consideration.

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel requested a review from jlaur August 30, 2024 09:01
@jlaur
Copy link
Contributor

jlaur commented Sep 2, 2024

I have added a comment in the linked issue with a few thoughts and proposals: #10376 (comment)

@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Oct 5, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, almost missed this: Can you regenerate I18N after adding the new parameter?

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Copy link
Contributor Author

lsiepel commented Oct 7, 2024

Sorry, almost missed this: Can you regenerate I18N after adding the new parameter?

My bad, totally forgot.

@jlaur jlaur merged commit b36877e into openhab:main Oct 7, 2024
4 of 5 checks passed
@jlaur jlaur added this to the 4.3 milestone Oct 7, 2024
@lsiepel lsiepel deleted the pushover-eof branch October 7, 2024 21:36
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pushover] Sending messages randomly fails with java.io.EOFException
3 participants