Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[somfytahoma] Switch Tahoma to OAUTH2 authentication #17361

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

octa22
Copy link
Contributor

@octa22 octa22 commented Sep 2, 2024

This PR should improve stability of the binding and fix #14763

More testing warmly welcomed, especially the Cozytouch OAUTH, Tahoma confirmed to be working fine by several users.

@octa22 octa22 added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Sep 2, 2024
@lolodomo
Copy link
Contributor

I will try to test for Cozytouch.

@octa22 octa22 force-pushed the somfytahoma-binding-oauth-4.3.x branch 2 times, most recently from f4d0efb to 64e9a3c Compare October 14, 2024 19:56
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
@octa22 octa22 force-pushed the somfytahoma-binding-oauth-4.3.x branch from 64e9a3c to a3ff1d8 Compare October 15, 2024 19:07
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 970ca59 into openhab:main Oct 15, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Oct 15, 2024
@lolodomo lolodomo removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Oct 15, 2024
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[somfytahoma] Too many attempts with an invalid token, temporarily banned.
2 participants