Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[emotiva] Fix missing data in source channels #17365

Merged
merged 2 commits into from
Sep 28, 2024
Merged

[emotiva] Fix missing data in source channels #17365

merged 2 commits into from
Sep 28, 2024

Conversation

espenaf
Copy link
Contributor

@espenaf espenaf commented Sep 3, 2024

Fixes #17363

Can be backported to 4.2.x

@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Sep 3, 2024
@lsiepel lsiepel changed the title [emotiva] Fixes issue with missing data in source channels [emotiva] Fix missing data in source channels Sep 3, 2024
@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Sep 6, 2024
lsiepel
lsiepel requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left two minor comments.
Fine to merge for 4.3.0, for backporting, it would be nice to also have a user confirmed test to minimalise the risks for regression.

...ing.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaUdpSendingService.java Show resolved Hide resolved
...ing.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaUdpSendingService.java Outdated Show resolved Hide resolved
@espenaf espenaf force-pushed the emotiva-sources-fix branch from 98b35a0 to 365ba9d Compare September 10, 2024 04:08
@espenaf
Copy link
Contributor Author

espenaf commented Sep 10, 2024

Thanks, left two minor comments. Fine to merge for 4.3.0, for backporting, it would be nice to also have a user confirmed test to minimalise the risks for regression.

Fixed the minor things. Where you thinking of an unit test or an actual user test?

@lsiepel
Copy link
Contributor

lsiepel commented Sep 10, 2024

Thanks, left two minor comments. Fine to merge for 4.3.0, for backporting, it would be nice to also have a user confirmed test to minimalise the risks for regression.

Fixed the minor things. Where you thinking of an unit test or an actual user test?

Depends on the extend of the unit tests. Add tests if you can and will see,

@lsiepel
Copy link
Contributor

lsiepel commented Sep 18, 2024 •
edited
Loading

@espenaf do you plan to add unit tests to this PR?

@espenaf
Copy link
Contributor Author

espenaf commented Sep 19, 2024

@espenaf do you plan to add unit tests to this PR?

I have started looking into it, but discovered I need to refactor a few things to be able to write some proper tests for this. Hopefully I will get it done over the weekend, but it could also be a separate PR to not cram to many changes into this fix.

lsiepel
lsiepel requested changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing some tests! Left some comments, i think these are the last ones. There is also a conflict to resolve.

...ding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaProcessorHandler.java Show resolved Hide resolved
...ding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaProcessorHandler.java Outdated Show resolved Hide resolved
...ding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaProcessorHandler.java Outdated Show resolved Hide resolved
...inding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaProcessorState.java Outdated Show resolved Hide resolved
...inding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaProcessorState.java Outdated Show resolved Hide resolved
@espenaf
[emotiva] Fixes issue with missing data in source channels.
9c4b198 
Signed-off-by: Espen Fossen <espenaf@junta.no>
@espenaf espenaf force-pushed the emotiva-sources-fix branch 2 times, most recently from 7169948 to 1add674 Compare September 28, 2024 12:36
@espenaf
[emotiva] Fixes issue with missing data in source channels.
85fc0bf 
Signed-off-by: Espen Fossen <espenaf@junta.no>
@espenaf espenaf force-pushed the emotiva-sources-fix branch from 1add674 to 85fc0bf Compare September 28, 2024 12:44
lsiepel
lsiepel approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit 2e7dde9 into openhab:main Sep 28, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Sep 28, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Sep 28, 2024

How critical is this and justifies that the risk to backport, @espenaf wdyt?

@espenaf
Copy link
Contributor Author

espenaf commented Sep 28, 2024

How critical is this and justifies that the risk to backport, @espenaf wdyt?

Missing the ability to change the source is quiet a key feature of an Processor/Reciever. The issue is also triggered by a race condition, so in that regard might be a very sporadic and unexplainable issue. This combination makes its justifier in my mind. It did become a bigger change than I was thinking, but in hindsight I should have coded it like this in the first place.

@lsiepel
Copy link
Contributor

lsiepel commented Sep 28, 2024

Unfortunately backporting is causing merge conflicts, so i can't backport.

@espenaf
Copy link
Contributor Author

espenaf commented Sep 29, 2024 •
edited
Loading

Unfortunately backporting is causing merge conflicts, so i can't backport.

Ok. I will put up som info on the community thread about the issue, so people can consider upgrading to 4.3.0-SNAPSHOT if they are experiencing it.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/emotiva-av-processor-binding/154406/2

joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@espenaf @joni1993
[emotiva] Fix missing data in source channels (openhab#17365)
4f59698 
* [emotiva] Fixes issue with missing data in source channels.

Signed-off-by: Espen Fossen <espenaf@junta.no>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@espenaf @matchews
[emotiva] Fix missing data in source channels (openhab#17365)
2eaa640 
* [emotiva] Fixes issue with missing data in source channels.

Signed-off-by: Espen Fossen <espenaf@junta.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[emotiva] Source channels are not listing items recevied from device
3 participants
@espenaf @lsiepel @openhab-bot