Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[evcc] Fix IllegalArgumentException for specific vehicle Id's #17380

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Sep 7, 2024

The vehicle Id is grabbed from the remote API and used to construct an openHAB channel UID. When the vehicle Id contains a : the generated UID becomes invalid. This is fixed by replace the : by a -

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Sep 7, 2024
@lsiepel lsiepel requested a review from florian-h05 as a code owner September 7, 2024 13:40
@lsiepel
Copy link
Contributor Author

lsiepel commented Sep 7, 2024

Candidate for 4.2.x backporting

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 16a6853 into openhab:main Sep 9, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Sep 9, 2024
@lsiepel lsiepel deleted the evcc-vehiclename branch September 9, 2024 17:04
lsiepel added a commit to lsiepel/openhab-addons that referenced this pull request Sep 9, 2024
…hab#17380)

* Handle semicolon in car id

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel added a commit that referenced this pull request Sep 9, 2024
* Handle semicolon in car id

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added the patch A PR that has been cherry-picked to a patch release branch label Sep 9, 2024
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Sep 24, 2024
…hab#17380)

* Handle semicolon in car id

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
…hab#17380)

* Handle semicolon in car id

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
…hab#17380)

* Handle semicolon in car id

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
…hab#17380)

* Handle semicolon in car id

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[evcc] Data will not been updated
3 participants