-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[evcc] Fix IllegalArgumentException
for specific vehicle Id's
#17380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-addons into evcc-vehiclename
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Candidate for 4.2.x backporting |
florian-h05
approved these changes
Sep 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
lolodomo
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
lsiepel
added a commit
to lsiepel/openhab-addons
that referenced
this pull request
Sep 9, 2024
…hab#17380) * Handle semicolon in car id Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel
added a commit
that referenced
this pull request
Sep 9, 2024
* Handle semicolon in car id Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel
added
the
patch
A PR that has been cherry-picked to a patch release branch
label
Sep 9, 2024
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Sep 24, 2024
…hab#17380) * Handle semicolon in car id Signed-off-by: Leo Siepel <leosiepel@gmail.com>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…hab#17380) * Handle semicolon in car id Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…hab#17380) * Handle semicolon in car id Signed-off-by: Leo Siepel <leosiepel@gmail.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…hab#17380) * Handle semicolon in car id Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vehicle Id is grabbed from the remote API and used to construct an openHAB channel
UID
. When the vehicle Id contains a:
the generated UID becomes invalid. This is fixed by replace the:
by a-