Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kaleidescape] Improve volume event handling #17387

Merged
merged 1 commit into from
Sep 8, 2024
Merged

[kaleidescape] Improve volume event handling #17387

merged 1 commit into from
Sep 8, 2024

Conversation

mlobstein
Copy link
Contributor

This PR implements the following improvements:

  • Improve handling of volume events from IR remotes (i.e. KREMOTE-STRATO, KREMOTE-20). MUTE_TOGGLE events were not published to the user_defined_event channel by the previous implementation.
  • Add an additional thing configuration parameter 'volumeBasicEnabled' that configures the Kaleidescape iPad and phone apps for stateless volume up/down and mute controls.
  • Provide additional rule examples for both volume handling scenarios.
  • Improve exiting rule examples and documentation.

@mlobstein
Improve volume event handling
d2c0f8d 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein mlobstein added the enhancement An enhancement or new feature for an existing add-on label Sep 8, 2024
lsiepel
lsiepel approved these changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit 2fb5740 into openhab:main Sep 8, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Sep 8, 2024
@mlobstein mlobstein deleted the kaleidescape_volume branch September 8, 2024 14:29
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Sep 24, 2024
@mlobstein @digitaldan
Improve volume event handling (openhab#17387)
da8f71e 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@mlobstein @pgfeller
Improve volume event handling (openhab#17387)
adb6b27 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@mlobstein @joni1993
Improve volume event handling (openhab#17387)
03e5b6c 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@mlobstein @matchews
Improve volume event handling (openhab#17387)
71b1980 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@mlobstein @lsiepel