Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homematic] Fix NullPointerException in discovery #17390

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

soenkekueper
Copy link
Contributor

@soenkekueper soenkekueper commented Sep 8, 2024

Fixed a NPE caused due new check introduced in #17206
fixes #17372

Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
@soenkekueper soenkekueper added the bug An unexpected problem or unintended behavior of an add-on label Sep 8, 2024
@lsiepel lsiepel changed the title [homematic] #17372: Fixed NPE [homematic] Fix NullPointerException in discovery Sep 8, 2024
Introduced local variables for gateway.

Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Copy link
Contributor

@maniac103 maniac103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just got 2 nitpicks.

Signed-off-by: maniac103 <dannybaumann@web.de>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 5c6b74b into openhab:main Sep 16, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Sep 16, 2024
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Sep 24, 2024
* openhab#17372: Fixed NPE

Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* openhab#17372: Fixed NPE

Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* openhab#17372: Fixed NPE

Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[homematic] NPE on startup
4 participants