-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[homematic] Fix NullPointerException
in discovery
#17390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
soenkekueper
added
the
bug
An unexpected problem or unintended behavior of an add-on
label
Sep 8, 2024
maniac103
reviewed
Sep 8, 2024
...n/java/org/openhab/binding/homematic/internal/discovery/HomematicDeviceDiscoveryService.java
Show resolved
Hide resolved
lsiepel
changed the title
[homematic] #17372: Fixed NPE
[homematic] Fix Sep 8, 2024
NullPointerException
in discovery
lsiepel
reviewed
Sep 8, 2024
...n/java/org/openhab/binding/homematic/internal/discovery/HomematicDeviceDiscoveryService.java
Outdated
Show resolved
Hide resolved
Introduced local variables for gateway. Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
maniac103
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just got 2 nitpicks.
...n/java/org/openhab/binding/homematic/internal/discovery/HomematicDeviceDiscoveryService.java
Outdated
Show resolved
Hide resolved
...n/java/org/openhab/binding/homematic/internal/discovery/HomematicDeviceDiscoveryService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: maniac103 <dannybaumann@web.de>
lolodomo
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Sep 24, 2024
* openhab#17372: Fixed NPE Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
* openhab#17372: Fixed NPE Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
* openhab#17372: Fixed NPE Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a NPE caused due new check introduced in #17206
fixes #17372