Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dscalarm] Remove org.apache.commons.net.util.SubnetUtils #17407

Merged
merged 3 commits into from
Oct 13, 2024
Merged

[dscalarm] Remove org.apache.commons.net.util.SubnetUtils #17407

merged 3 commits into from
Oct 13, 2024

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Sep 12, 2024

  • Remove org.apache.commons

Depends on : openhab/openhab-core#4375

@lsiepel
Remove apache
504cfff 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added the awaiting other PR Depends on another PR label Sep 12, 2024
@lsiepel lsiepel requested a review from RSStephens as a code owner September 12, 2024 12:06
@lsiepel lsiepel added enhancement An enhancement or new feature for an existing add-on and removed awaiting other PR Depends on another PR labels Oct 7, 2024
@lsiepel lsiepel requested a review from a team October 11, 2024 12:32
lolodomo
lolodomo approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

@lolodomo lolodomo merged commit 1d67d97 into openhab:main Oct 13, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Oct 13, 2024
@lsiepel lsiepel deleted the dscalarm-remove-apache branch October 13, 2024 12:26
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@lsiepel @joni1993
[dscalarm] Remove org.apache.commons.net.util.SubnetUtils (openhab#17407
e1a6a72 
)

* Remove apache

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@lsiepel @matchews
[dscalarm] Remove org.apache.commons.net.util.SubnetUtils (openhab#17407
4234639 
)

* Remove apache

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
@lsiepel
[dscalarm] Remove org.apache.commons.net.util.SubnetUtils (openhab#17407
75b7783 
)

* Remove apache

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@RSStephens RSStephens Awaiting requested review from RSStephens RSStephens is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@lsiepel @lolodomo