Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rrd4j] Avoid RrdDb.getRrdDef calls #17449

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

joerg1985
Copy link
Contributor

Calling RrdDb.getRrdDef will read several fields and create a complete RrdDef copy.
This PR will avoid this and read the needed information from the Header / Archive.

Signed-off-by: Jörg Sautter joerg.sautter@gmx.net

Signed-off-by: Jörg Sautter <joerg.sautter@gmx.net>
@joerg1985 joerg1985 requested a review from a team as a code owner September 20, 2024 11:55
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Sep 20, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 52ea5d6 into openhab:main Sep 20, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Sep 20, 2024
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Jörg Sautter <joerg.sautter@gmx.net>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Jörg Sautter <joerg.sautter@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants