Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[myuplink] Initial contribution #17451

Merged
merged 122 commits into from
Dec 3, 2024
Merged

[myuplink] Initial contribution #17451

merged 122 commits into from
Dec 3, 2024

Conversation

alexf2015
Copy link
Contributor

Description

This binding introduces a new binding which replaces both the official and the marketplace "nibeuplink" bindings. This is necessary due to the fact that the nibeuplink API is discontinued (since 01.09.2024, see https://www.nibeuplink.com/) by NIBE and replaced by a new one called "myUplink". This works in a totally different way and thus it was not possible to adopt the old binding.

I will handle removal of the old nibeuplink binding in a seperate PR.

Testing

The addon was made available already to the community and was tested by several users.
See this thread: https://community.openhab.org/t/myuplink-binding/154622/4

@alexf2015 alexf2015 requested a review from a team as a code owner September 20, 2024 15:30
@alexf2015 alexf2015 force-pushed the myuplink-dev branch 2 times, most recently from 0891c87 to d43a139 Compare September 21, 2024 11:47
@alexf2015 alexf2015 mentioned this pull request Sep 21, 2024
Merged
@alexf2015 alexf2015 added new binding If someone has started to work on a binding. For a new binding PR. awaiting feedback Awaiting feedback from the pull request author labels Sep 21, 2024
@alexf2015 alexf2015 changed the title [myuplink] new binding [myuplink] Initial contribution Sep 21, 2024
@lsiepel lsiepel removed the awaiting feedback Awaiting feedback from the pull request author label Sep 28, 2024
lsiepel
lsiepel requested changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at most meta files (documentation, thing structure etc) and wanted to give you some quick feedback. Bindings seems well organized. Please make sure all compiler warnings and SAT errors are fixed if not allready. When i have some more time i'll continue the review.

Edit: The codeowner file needs some attention.

bundles/org.openhab.binding.myuplink/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.myuplink/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.myuplink/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.myuplink/README.md Show resolved Hide resolved
bundles/org.openhab.binding.myuplink/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.myuplink/src/main/resources/OH-INF/thing/readonly-channel-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.myuplink/src/main/resources/OH-INF/i18n/myuplink.properties Outdated Show resolved Hide resolved
bundles/org.openhab.binding.myuplink/src/main/resources/OH-INF/config/config.xml Outdated Show resolved Hide resolved
...nk/src/main/java/org/openhab/binding/myuplink/internal/model/GenericResponseTransformer.java Outdated Show resolved Hide resolved
...uplink/src/main/java/org/openhab/binding/myuplink/internal/handler/MyUplinkThingHandler.java Outdated Show resolved Hide resolved
@lsiepel lsiepel requested a review from a team October 13, 2024 19:09
@lsiepel
Copy link
Contributor

lsiepel commented Oct 17, 2024

Somewhat buried #17451 (comment) @openhab/add-ons-maintainers wdyt?

lsiepel
lsiepel requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet covered all files, but ran out of time so i flush these pending comments so you can look at it.

CODEOWNERS Outdated Show resolved Hide resolved
bundles/org.openhab.binding.myuplink/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.myuplink/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.myuplink/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.myuplink/README.md Outdated Show resolved Hide resolved
.../org.openhab.binding.myuplink/src/main/java/org/openhab/binding/myuplink/internal/Utils.java Outdated Show resolved Hide resolved
.../org.openhab.binding.myuplink/src/main/java/org/openhab/binding/myuplink/internal/Utils.java Show resolved Hide resolved
...ng.myuplink/src/main/java/org/openhab/binding/myuplink/internal/provider/ChannelFactory.java Outdated Show resolved Hide resolved
.../src/main/java/org/openhab/binding/myuplink/internal/discovery/MyUplinkDiscoveryService.java Outdated Show resolved Hide resolved
.../src/main/java/org/openhab/binding/myuplink/internal/discovery/MyUplinkDiscoveryService.java Outdated Show resolved Hide resolved
@alexf2015
myuplink skeleton
a28b4a5 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
refactoring
450ecd3 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
refactoring
5c673d0 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
base config
9efdedd 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
skeleton WiP
d14734b 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
nibeId is not needed as global parameter
dc5f2ff 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
skeleton
0c6b0bc 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
WiP
8555713 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
WiP
65bd887 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
WiP
5cb1c7f 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
WiP: login successful!
2f8a723 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
finished login implementation
ea60eed 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
fixed dispose of Webinterface. fixed TokenRefresh
004e81a 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
WiP
a406d11 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
WiP
eab7278 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
alexf2015 and others added 6 commits November 8, 2024 17:00
@alexf2015 @lsiepel
Update bundles/org.openhab.binding.myuplink/src/main/java/org/openhab…
d334041 
…/binding/myuplink/internal/handler/MyUplinkGenericDeviceHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Alexander Friese <alexf2015@users.noreply.github.com>
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
revert as the change will not work (in my opinion)
00f8d4b 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
adoptions due to review
b612202 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
code review
ba316f4 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015 @lsiepel
Update bundles/org.openhab.binding.myuplink/src/main/java/org/openhab…
21381d9 
…/binding/myuplink/internal/handler/MyUplinkGenericDeviceHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Alexander Friese <alexf2015@users.noreply.github.com>
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
code review
dfa6c09 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
Copy link
Contributor Author

@lsiepel From my end all is done. There are some points left unresolved we either need to discuss it further or we leave it as it is.

@lsiepel
Copy link
Contributor

lsiepel commented Nov 9, 2024

For your convienience these 4 comments are not yet closed at this moment:
#17451 (comment)
#17451 (comment)
#17451 (comment)
#17451 (comment)

lsiepel
lsiepel requested changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 previous and 5 new comments. Otherwise LGTM.
I guess this was the last pass, getting close.

alexf2015 and others added 5 commits November 16, 2024 15:21
@alexf2015 @lsiepel
Update bundles/org.openhab.binding.myuplink/README.md
ae5055d 
Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Alexander Friese <alexf2015@users.noreply.github.com>
@alexf2015 @lsiepel
Update bundles/org.openhab.binding.myuplink/src/main/java/org/openhab…
3ec97f2 
…/binding/myuplink/internal/command/AbstractCommand.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Alexander Friese <alexf2015@users.noreply.github.com>
@alexf2015 @lsiepel
Update bundles/org.openhab.binding.myuplink/src/main/java/org/openhab…
5d07f75 
…/binding/myuplink/internal/command/AbstractCommand.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Alexander Friese <alexf2015@users.noreply.github.com>
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
applied dos2unix
65d8f64 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
fixed loglevel
9c7117f 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
alexf2015 and others added 2 commits November 22, 2024 08:48
@alexf2015 @lsiepel
Update bundles/org.openhab.binding.myuplink/README.md
33a6cc7 
Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Alexander Friese <alexf2015@users.noreply.github.com>
@alexf2015
Update README.md
e2a200e 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
lsiepel
lsiepel approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
All comments are addressed, i have no new ones. Thank you for this contribution. The feature freeze for 4.3.0 is in a week. Do you need any additional testing?
Without any further notice i will merge this by the end of this week.

@alexf2015
Copy link
Contributor Author

I am already using this binding in my production setup for about 6 months. Others are also using it. Therefore I am quite sure that it is ready to be released.

@lsiepel lsiepel merged commit 36bde00 into openhab:main Dec 3, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Dec 3, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Dec 3, 2024

Next step would be to add the binding logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website

@lsiepel lsiepel mentioned this pull request Dec 5, 2024
Merged
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
@alexf2015 @matchews
[myuplink] Initial contribution (openhab#17451)
8fe8359 
* myuplink skeleton

Signed-off-by: Alexander Friese <af944580@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@alexf2015 @lsiepel @pacive