-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[energidataservice] Introduce subscription-based providers #17456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaur
added
enhancement
An enhancement or new feature for an existing add-on
additional testing preferred
The change works for the pull request author. A test from someone else is preferred though.
labels
Sep 21, 2024
jlaur
force-pushed
the
energidataservice-provider
branch
5 times, most recently
from
September 27, 2024 20:25
25f33e7
to
e12a31d
Compare
jlaur
removed
the
additional testing preferred
The change works for the pull request author. A test from someone else is preferred though.
label
Sep 28, 2024
lsiepel
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty solid. Nice improvement. Just one comment
...va/org/openhab/binding/energidataservice/internal/provider/listener/Co2EmissionListener.java
Show resolved
Hide resolved
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
force-pushed
the
energidataservice-provider
branch
from
October 11, 2024 13:51
e12a31d
to
68b236c
Compare
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
force-pushed
the
energidataservice-provider
branch
from
October 11, 2024 13:58
68b236c
to
d9fa094
Compare
lsiepel
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…7456) * Introduce subscription-based providers Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…7456) * Introduce subscription-based providers Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the binding to use a subscription-based model for better separation of responsibilities and preparing for the future:
Additionally:
Impact of this refactoring: