Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SenecHome] Add writeable Charging Modes #17474

Merged
merged 6 commits into from
Oct 5, 2024

Conversation

BigFood2307
Copy link
Contributor

This PR improves the SenecHome Binding by adding access to two writable charging modes for the battery systems.
This means adding the general capability of write commands to the binding and implementing the HTTPS commands for the necessary parameters.
It was shortly discussed in the Bindings Forum thread
With this addition the user can now force the battery system to charge to full or enter it into storage/transport mode.

Only one other person was able to test the new version. They had issues, although that might have been due to missmatched openHab versions.
On my own system, the updated binding has been running for ~6 months without issue.
Here is the binary I have been using for oh 4.2

Direct link to jfrog for convenience, since the template asked me to :)
https://openhab.jfrog.io/ui/native/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.senechome/

@BigFood2307 BigFood2307 force-pushed the senechome-charge-commands branch from a97e258 to a0311ee Compare September 24, 2024 17:41
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Sep 24, 2024
Copy link
Contributor

@vich-667 vich-667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Looks good to me, also compared to the info I could reverse engineer from my senecs web interface. I can't test it, because my senec is one them which are not working and I still waiting for replacement since about a year.

@lsiepel
Copy link
Contributor

lsiepel commented Sep 26, 2024

How do these two charging modes relate? From the descriptions they seem conflicting, If you turn on both switches, what will happen?

Did you consider to have one chargeMode channel, that contains a list of possible options like: lithium charge, safe charge, nomale charge mode etc. ?

@BigFood2307
Copy link
Contributor Author

How do these two charging modes relate? From the descriptions they seem conflicting, If you turn on both switches, what will happen?

True, they are conflicting. I think I tested it some time ago and turning a second mode on, it would turn the first one back off.
I can test that again on the weekend.

Did you consider to have one chargeMode channel, that contains a list of possible options like: lithium charge, safe charge, nomale charge mode etc. ?

A single channel with 3 options never entered my mind, but could actually be a good idea. I will look into how I can implement fixed state options for the channel.

@BigFood2307
Copy link
Contributor Author

Thanks for the feedback!
I did some testing and can now confirm, that Storage Mode always just overrides Safe Charge Mode.
I still think the idea of combining them into one channel was good, so I implemented that now.

Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>
Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>
Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>
Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>
@BigFood2307 BigFood2307 force-pushed the senechome-charge-commands branch from f2a9a4c to e75d468 Compare October 5, 2024 10:34
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some textual improvements now this has changed. I think this was a good move to this list instead of the switches, thank you. We expect a milestone this weekend, so if you are able to look at it today we can get it into 4.3.0m2

BigFood2307 and others added 2 commits October 5, 2024 15:30
Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Lukas Pindl <36566235+BigFood2307@users.noreply.github.com>
Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>
@BigFood2307
Copy link
Contributor Author

Should now be fixed 👍

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@lsiepel lsiepel added this to the 4.3 milestone Oct 5, 2024
@lsiepel lsiepel merged commit 5c99a6c into openhab:main Oct 5, 2024
4 of 5 checks passed
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* [senechome] Now accepts commands for active charging

Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>

* [senechome] Manual update for charging modes

Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>

* [senechome] docu and spotless

Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>

* [Senechome] Charge Modes combined into a single channel

Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>

* [senechome] Apply suggestions from code review

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Lukas Pindl <36566235+BigFood2307@users.noreply.github.com>

* [senechome] additional review fixes

Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>

---------

Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>
Signed-off-by: Lukas Pindl <36566235+BigFood2307@users.noreply.github.com>
Co-authored-by: lsiepel <leosiepel@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* [senechome] Now accepts commands for active charging

Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>

* [senechome] Manual update for charging modes

Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>

* [senechome] docu and spotless

Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>

* [Senechome] Charge Modes combined into a single channel

Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>

* [senechome] Apply suggestions from code review

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Lukas Pindl <36566235+BigFood2307@users.noreply.github.com>

* [senechome] additional review fixes

Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>

---------

Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>
Signed-off-by: Lukas Pindl <36566235+BigFood2307@users.noreply.github.com>
Co-authored-by: lsiepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants