-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SenecHome] Add writeable Charging Modes #17474
Conversation
a97e258
to
a0311ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks good to me, also compared to the info I could reverse engineer from my senecs web interface. I can't test it, because my senec is one them which are not working and I still waiting for replacement since about a year.
How do these two charging modes relate? From the descriptions they seem conflicting, If you turn on both switches, what will happen? Did you consider to have one |
True, they are conflicting. I think I tested it some time ago and turning a second mode on, it would turn the first one back off.
A single channel with 3 options never entered my mind, but could actually be a good idea. I will look into how I can implement fixed state options for the channel. |
Thanks for the feedback! |
Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>
Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>
Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>
Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>
f2a9a4c
to
e75d468
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some textual improvements now this has changed. I think this was a good move to this list instead of the switches, thank you. We expect a milestone this weekend, so if you are able to look at it today we can get it into 4.3.0m2
...hab.binding.senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeApi.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.senechome/src/main/resources/OH-INF/i18n/senechome.properties
Outdated
Show resolved
Hide resolved
...binding.senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeHandler.java
Outdated
Show resolved
Hide resolved
...enechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeBindingConstants.java
Outdated
Show resolved
Hide resolved
...binding.senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeHandler.java
Outdated
Show resolved
Hide resolved
Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Lukas Pindl <36566235+BigFood2307@users.noreply.github.com>
Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net>
Should now be fixed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM
* [senechome] Now accepts commands for active charging Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net> * [senechome] Manual update for charging modes Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net> * [senechome] docu and spotless Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net> * [Senechome] Charge Modes combined into a single channel Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net> * [senechome] Apply suggestions from code review Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Lukas Pindl <36566235+BigFood2307@users.noreply.github.com> * [senechome] additional review fixes Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net> --------- Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net> Signed-off-by: Lukas Pindl <36566235+BigFood2307@users.noreply.github.com> Co-authored-by: lsiepel <leosiepel@gmail.com>
* [senechome] Now accepts commands for active charging Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net> * [senechome] Manual update for charging modes Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net> * [senechome] docu and spotless Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net> * [Senechome] Charge Modes combined into a single channel Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net> * [senechome] Apply suggestions from code review Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Lukas Pindl <36566235+BigFood2307@users.noreply.github.com> * [senechome] additional review fixes Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net> --------- Signed-off-by: Lukas Pindl <lukas.pindl@gmx.net> Signed-off-by: Lukas Pindl <36566235+BigFood2307@users.noreply.github.com> Co-authored-by: lsiepel <leosiepel@gmail.com>
This PR improves the SenecHome Binding by adding access to two writable charging modes for the battery systems.
This means adding the general capability of write commands to the binding and implementing the HTTPS commands for the necessary parameters.
It was shortly discussed in the Bindings Forum thread
With this addition the user can now force the battery system to charge to full or enter it into storage/transport mode.
Only one other person was able to test the new version. They had issues, although that might have been due to missmatched openHab versions.
On my own system, the updated binding has been running for ~6 months without issue.
Here is the binary I have been using for oh 4.2
Direct link to jfrog for convenience, since the template asked me to :)
https://openhab.jfrog.io/ui/native/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.senechome/