Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Markdown code block languages consistent #17480

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Make Markdown code block languages consistent #17480

merged 2 commits into from
Sep 29, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Sep 28, 2024 •
edited
Loading

This should improve syntax highlighting.

@jlaur
Make Markdown code block languages consistent
b6ef075 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
stefan-hoehn
stefan-hoehn approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for cleaning up the campground #boyscout-rule ;-) 🙏🏻

@jlaur
Fix indentation
6089488 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrewfg
andrewfg approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM growatt
LGTM hdpowerview
LGTM hue
LGTM velux

@lsiepel
Copy link
Contributor

lsiepel commented Sep 29, 2024

Thanks, LGTM

@lsiepel lsiepel merged commit 85b1652 into openhab:main Sep 29, 2024
3 of 5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Sep 29, 2024
@jlaur jlaur deleted the documentation-code-language-consistency branch September 29, 2024 10:56
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@jlaur @joni1993
Make Markdown code block languages consistent (openhab#17480)
5747193 
* Make Markdown code block languages consistent

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Fix indentation

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

---------

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@jlaur @matchews
Make Markdown code block languages consistent (openhab#17480)
24bb53a 
* Make Markdown code block languages consistent

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Fix indentation

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

---------

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
@jlaur
Make Markdown code block languages consistent (openhab#17480)
08e3ea0 
* Make Markdown code block languages consistent

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Fix indentation

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

---------

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewfg andrewfg andrewfg approved these changes

@stefan-hoehn stefan-hoehn stefan-hoehn approved these changes

@lsiepel lsiepel lsiepel approved these changes

@GiviMAD GiviMAD Awaiting requested review from GiviMAD GiviMAD is a code owner

@clinique clinique Awaiting requested review from clinique clinique is a code owner

@zarusz zarusz Awaiting requested review from zarusz zarusz is a code owner

@gs4711 gs4711 Awaiting requested review from gs4711 gs4711 is a code owner

@Skinah Skinah Awaiting requested review from Skinah Skinah is a code owner

@peuter peuter Awaiting requested review from peuter peuter is a code owner

@Stratehm Stratehm Awaiting requested review from Stratehm Stratehm is a code owner

@pail23 pail23 Awaiting requested review from pail23 pail23 is a code owner

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

@weymann weymann Awaiting requested review from weymann weymann is a code owner

@ppieczul ppieczul Awaiting requested review from ppieczul ppieczul is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@andylintner andylintner Awaiting requested review from andylintner andylintner is a code owner

@mhilbush mhilbush Awaiting requested review from mhilbush mhilbush is a code owner

@lujop lujop Awaiting requested review from lujop lujop is a code owner

@caffineehacker caffineehacker Awaiting requested review from caffineehacker caffineehacker is a code owner

@mgeramb mgeramb Awaiting requested review from mgeramb mgeramb is a code owner

@wborn wborn Awaiting requested review from wborn wborn is a code owner

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@jlaur @lsiepel @andrewfg @stefan-hoehn