Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unifi] Add support for new thing type access point #17499

Merged
merged 48 commits into from
Oct 4, 2024
Merged

[unifi] Add support for new thing type access point #17499

merged 48 commits into from
Oct 4, 2024

Conversation

DrRSatzteil
Copy link
Contributor

@DrRSatzteil DrRSatzteil commented Oct 3, 2024 •
edited
Loading

[unifi] Add support for new thing type access point

Description

This PR adds a new thing type "accessPoint" to the unifi binding. Right now the binding allows you to disable complete wifi networks which affects all access points that are configured to provide this network. However it is not yet possible to just disable individual access points to disable wifi coverage in certain areas. Also disabling access points will switch off all radio activity of the device and may be used to reduce emissions and save power in in times when no wifi coverage is needed for the area covered by this access point.

Testing

https://openhab.jfrog.io/artifactory/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.unifi/4.3.0-SNAPSHOT/org.openhab.binding.unifi-4.3.0-SNAPSHOT.jar

@DrRSatzteil DrRSatzteil changed the title Unifi [unifi] Add support for new thing type access point Oct 3, 2024
DrRSatzteil added 27 commits October 3, 2024 17:37
Initial commit
aba268b 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Lots of fixes and improvements
025d02e 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Repeat property is evil!
281b085 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Updated thing descriptions and cleanup
b4c89e4 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Fixed command handling for bridge
374a7b2 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Fixed blinkIndicator action
6a52431 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Cleanup
937418b 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Removed ColorTemp tag from effectPalette
a2613ca 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Send None as effectPalette value to reset
29b3e60 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Prevent DiscoveryService from receiving retained app messages
a7a6538 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Missing slash added
5f2d242 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Various fixes and improvements
740833d 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Initialise all items (no more UNDEF types)
03a9e75 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Increased init wait time
414c83f 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Smoother app initialisation
8d437bf 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Fixed display command
e31a09f 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Channel impr. / dont accept commands during sync
9121f1c 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Brightness settings working now
5911d66 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
pushIcon fixed, faster init
e3f601f 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Removed unused buttonControl channel
88834a5 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Set app active when found in rotation
c3afa9d 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Initial notification impl
6940ffb 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Added custom notifications
8ad7c29 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Fixed trigger channels
45d15fc 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Map stats.matrix field added in AL 0.89
9da914e 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Added DSL Rule Action support
80adca6 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Spotless and pom version fixes
eeedc8c 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
@DrRSatzteil
Copy link
Contributor Author

It might make sense to inverse the "disabled" logic for this binding: it seems counter intuitive to switch an item ON to actually disable the access point...

inverted disable/enable logic
1f966eb 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
@DrRSatzteil
Copy link
Contributor Author

It might make sense to inverse the "disabled" logic for this binding: it seems counter intuitive to switch an item ON to actually disable the access point...

The more I thought about it and used the new things in my setup the more absurd it seemed to me. So I decided to invert the logic for now. Please advise if you think it should be done otherwise...

jlaur
jlaur requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice addition! The code looks very clean and consistent with the existing binding code.

@Hilbrand and @mgbowman, would you like to have a look as well?

@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Oct 3, 2024
@DrRSatzteil @jlaur
thing-types.xml aktualisieren
a2c4c31 
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Thomas Lauterbach <2452988+DrRSatzteil@users.noreply.github.com>
@DrRSatzteil
Copy link
Contributor Author

Oh and I guess I have to add the site to the thing config just like for the Clients

DrRSatzteil added 4 commits October 4, 2024 08:35
fixes various review comments
0eeebba 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
added missing site config for ap
a78d7bb 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
dont provide the site as channel
46de992 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
fixed representation property
8d14e65 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
Hilbrand
Hilbrand requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the accessPoint. I've some style related comments.

DrRSatzteil added 2 commits October 4, 2024 09:30
fixes style issues mentioned ni review comments
8a02ae8 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
another style change from review
ee4bfa4 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
@DrRSatzteil DrRSatzteil requested review from jlaur and Hilbrand October 4, 2024 10:36
Hilbrand
Hilbrand approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only need to remove the already done ToDo.

@DrRSatzteil @jlaur
remove todo
0230e4b 
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Thomas Lauterbach <2452988+DrRSatzteil@users.noreply.github.com>
@DrRSatzteil
Copy link
Contributor Author

Yes that ToDo is done already. I removed the comment.

jlaur
jlaur reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor comment, otherwise LGTM. I have also reopened a previous one regarding the channel id in the README.

corrected channel id for ap and properties cleanup
09afb09 
Signed-off-by: DrRSatzteil <thomas_lauterbach@arcor.de>
@DrRSatzteil DrRSatzteil requested a review from jlaur October 4, 2024 15:29
jlaur
jlaur approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit a11460c into openhab:main Oct 4, 2024
4 of 5 checks passed
@jlaur jlaur added this to the 4.3 milestone Oct 4, 2024
@DrRSatzteil DrRSatzteil deleted the unifi branch October 4, 2024 15:56
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/ubiquiti-unifi-binding-feature-discussion/14520/1302

joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@DrRSatzteil @joni1993
[unifi] Add support for new thing type access point (openhab#17499)
f6fe51c 
Signed-off-by: Thomas Lauterbach <thomas_lauterbach@arcor.de>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@DrRSatzteil @matchews
[unifi] Add support for new thing type access point (openhab#17499)
05a8c66 
Signed-off-by: Thomas Lauterbach <thomas_lauterbach@arcor.de>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
@DrRSatzteil
[unifi] Add support for new thing type access point (openhab#17499)
260f3e6 
Signed-off-by: Thomas Lauterbach <thomas_lauterbach@arcor.de>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand approved these changes

@jlaur jlaur jlaur approved these changes

@mgbowman mgbowman Awaiting requested review from mgbowman mgbowman is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@DrRSatzteil @openhab-bot @Hilbrand @jlaur