[kaleidescape] Switch to SDDP discovery for Strato and Alto #17508
Conversation
mlobstein
added
the
regression
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
mlobstein
force-pushed
the
kaleidescape_sddp
branch
from
4fed5a5 to
153e762
Compare
mlobstein
added
rebuild
There was a problem hiding this comment.
Thanks, LGTM.
As this is a regression to switch to SSDP, does this affect the discovery of any device (like the added support for Strato V) ? There is no functional downside to this?
Regarding the release notes. As this partly overrwrites the previous PR we need to remove the regression label as otherwise it won't show up in the release notes leaving the user to think UpnP support is added, while it is actually SSDP.
lsiepel
added
bug
I was just able to test with an older Strato and discovered the bug with UPnP. All devices in the Strato range are said to run the same kOS version so it is fairly safe to assume that the bug and also this fix will apply to all Strato devices. |
mlobstein
changed the title
|
UPnP on this device is failing to work with jUPnP because the |
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Regression of #17371. UPnP discovery does not work due to an invalid deviceType field in the device description.xml. Accordingly, this PR changes the discovery participant to use SDDP instead.