Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ipcamera] Improve onvif events with an auto restart feature #17518

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

Skinah
Copy link
Contributor

@Skinah Skinah commented Oct 7, 2024

  • Refactor to use a switch statement instead of .contains
  • Add an auto restart to the event stream if a camera closes the request without making a valid ONVIF reply.
  • Improve date and time check to ensure the time is in sync with openHAB.

Signed-off-by: Matthew Skinner matt@pcmus.com

Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah Skinah added the enhancement An enhancement or new feature for an existing add-on label Oct 7, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, otherwise LGTM

@lsiepel lsiepel changed the title [ipcamera] Refactor and improve onvif events with an auto restart feature [ipcamera] RImprove onvif events with an auto restart feature Oct 7, 2024
@lsiepel lsiepel changed the title [ipcamera] RImprove onvif events with an auto restart feature [ipcamera] Improve onvif events with an auto restart feature Oct 7, 2024
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@lsiepel lsiepel merged commit 989093c into openhab:main Oct 11, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Oct 11, 2024
@Skinah Skinah deleted the ipcamera branch October 11, 2024 21:54
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
…#17518)

* Refactor and improve onvif events with auto restart.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
…#17518)

* Refactor and improve onvif events with auto restart.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
…#17518)

* Refactor and improve onvif events with auto restart.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants