-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[evcc] Fix API change on duration channels #17528
Conversation
Signed-off-by: Michael Weger <weger.michael@gmx.net>
This change looks fine, but it also makes me wonder if we can implement some kind of schema versioning. |
EVCC status API provides the version info, e.g. "version":"0.130.13". This could be used to support different versions in parallel. Nevertheless, I fear that I will not be able to implement such a feature in the near future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
Regarding the versioning, fully understand this is time consuming, good to knwo there is a version string we can depend on. Implementing schema verisoning is not that simple if the remote API hardly supports generic/dynamic structures.
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Michael Weger <weger.michael@gmx.net>
[evcc] API change on duration channels
Since EVCC version 0.127.0 (evcc-io/evcc#13319) the EVCC Rest API duration states are in seconds instead of nanoseconds.
Current EVCC implementation still treats them as Nano-Seconds. E.g.:
Fixes the following issues: