[mqtt.homeassistant] Implement non-deprecated color inference for JSON Schema Lights #17529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…N Schema lights In particular, use the color_mode attribute to tell us which color space to parse in, instead of trying to guess. Some devices will fill out attributes not-pertinent to the current color mode, and their math might be... less than optimal. Also sync color temp and color channels when the color_mode is the opposite. Signed-off-by: Cody Cutrer <cody@cutrer.us>
lsiepel
added
the
enhancement
lsiepel
changed the title
ccutrer
deleted the
mqtt-homeassistant-non-deprecated-json-schema-light-color
branch
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…N Schema lights (openhab#17529) In particular, use the color_mode attribute to tell us which color space to parse in, instead of trying to guess. Some devices will fill out attributes not-pertinent to the current color mode, and their math might be... less than optimal. Also sync color temp and color channels when the color_mode is the opposite. Signed-off-by: Cody Cutrer <cody@cutrer.us>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…N Schema lights (openhab#17529) In particular, use the color_mode attribute to tell us which color space to parse in, instead of trying to guess. Some devices will fill out attributes not-pertinent to the current color mode, and their math might be... less than optimal. Also sync color temp and color channels when the color_mode is the opposite. Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, use the color_mode attribute to tell us which color space to parse in, instead of trying to guess. Some devices will fill out attributes not-pertinent to the current color mode, and their math might be... less than optimal. Also sync color temp and color channels when the color_mode is the opposite.