Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[insteon] Refactor msg definition/factory and product data classes #17537

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

jsetton
Copy link
Contributor

@jsetton jsetton commented Oct 10, 2024

This change refactors the transport message definition/factory classes improving the separation between a Msg object and the MsgDefinition object it is derived from, and the error handling when parsing new data in the MsgFactory class. Some minor refactoring was added for the ProductData and InsteonScene classes.

Signed-off-by: jsetton <jeremy.setton@gmail.com>
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Oct 10, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

This and the other refactorings are greatly appreciated. As we usually expect a stable release by Christmas, i think we should focus on regression testing and bug fixing.

@lsiepel lsiepel merged commit 7a5ba4e into openhab:main Oct 10, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Oct 10, 2024
@jsetton jsetton deleted the insteon-refactor branch October 10, 2024 19:17
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants