Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ipcamera]Fix SceneChange alarm not working for newer Dahua cameras #17544

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

Skinah
Copy link
Contributor

@Skinah Skinah commented Oct 12, 2024

PR does the following:

  • Fixes a major bug that stops mjpeg from getting fetched from a camera if the user enters their own URL. Code strips the IP and port from the requestUrl so it never matches the user entered URL.
  • Minor improvements for Dahua users that were picked up when running tests with a newer camera.
  • Fix minor compiler warnings.

User reported this bug here on the forum
https://community.openhab.org/t/ipcamera-new-ip-camera-binding/42771/2977

Signed-off-by: Matthew Skinner matt@pcmus.com

Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah Skinah added the bug An unexpected problem or unintended behavior of an add-on label Oct 12, 2024
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/ipcamera-new-ip-camera-binding/42771/2979

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@lsiepel lsiepel merged commit c6b2e2d into openhab:main Oct 12, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Oct 12, 2024
@Skinah Skinah changed the title [ipcamera]Fix mjpeg does not work if overridden by user [ipcamera]Fix SceneChange alarm not working for newer Dahua cameras Oct 13, 2024
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Matthew Skinner <matt@pcmus.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants