Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] Ensure expiresAt is usable #17553

Merged
merged 2 commits into from
Oct 13, 2024
Merged

[netatmo] Ensure expiresAt is usable #17553

merged 2 commits into from
Oct 13, 2024

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Oct 13, 2024 •
edited by jlaur
Loading

Resolves #17552

@clinique
Ensure expiresAt is usable
6f1a165 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique clinique requested a review from lolodomo as a code owner October 13, 2024 09:33
@clinique clinique self-assigned this Oct 13, 2024
@clinique clinique added the bug An unexpected problem or unintended behavior of an add-on label Oct 13, 2024
@clinique clinique changed the title [netatmo] Ensure expiresAt is present [netatmo] Ensure expiresAt is usable Oct 13, 2024
@clinique
Reorder comments
4f5d0e8 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
lolodomo
lolodomo approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 1e04957 into openhab:main Oct 13, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Oct 13, 2024
@clinique clinique deleted the netatmo_17552 branch October 13, 2024 13:49
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@clinique @joni1993
[netatmo] Ensure expiresAt is usable (openhab#17553)
a4998e1 
* Ensure expiresAt is usable

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@clinique @matchews
[netatmo] Ensure expiresAt is usable (openhab#17553)
9b41620 
* Ensure expiresAt is usable

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees

@clinique clinique

Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[netatmo] NPE in HomeEvent class
2 participants
@clinique @lolodomo