Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmiweather] Add support for edited Scandinavia forecast #17555

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Oct 13, 2024

Resolves #17548

Resolves openhab#17548

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added enhancement An enhancement or new feature for an existing add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Oct 13, 2024
@jlaur jlaur marked this pull request as ready for review October 15, 2024 18:13
@jlaur jlaur requested a review from ssalonen as a code owner October 15, 2024 18:13
Copy link
Contributor

@ssalonen ssalonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you once again! Great improvement

small comment on readme

bundles/org.openhab.binding.fmiweather/README.md Outdated Show resolved Hide resolved
@jlaur jlaur removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Oct 17, 2024
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/spot-price-optimizer-advanced-algorhitms-to-optimize-heating-charging-of-electric-vehicles-water-boilers-and-more/159539/1

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur force-pushed the fmiweather-edited-forecast branch from 5b564fe to dcef1c9 Compare October 19, 2024 12:45
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 170444b into openhab:main Oct 19, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Oct 19, 2024
@jlaur jlaur deleted the fmiweather-edited-forecast branch October 19, 2024 21:08
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
* Add support for edited Scandinavia forecast

Resolves openhab#17548

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
* Add support for edited Scandinavia forecast

Resolves openhab#17548

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
* Add support for edited Scandinavia forecast

Resolves openhab#17548

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fmiweather] Add possibility to use fmi::forecast::edited in addition to fmi::forecast::harmonie
5 participants