-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fmiweather] Add support for edited Scandinavia forecast #17555
Conversation
Resolves openhab#17548 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you once again! Great improvement
small comment on readme
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
5b564fe
to
dcef1c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment
...fmiweather/src/main/java/org/openhab/binding/fmiweather/internal/ForecastWeatherHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
* Add support for edited Scandinavia forecast Resolves openhab#17548 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Add support for edited Scandinavia forecast Resolves openhab#17548 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Add support for edited Scandinavia forecast Resolves openhab#17548 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Resolves #17548