Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tado] Add channel for remaining time of open window override #17576

Merged
merged 4 commits into from
Oct 21, 2024
Merged

[tado] Add channel for remaining time of open window override #17576

merged 4 commits into from
Oct 21, 2024

Conversation

andrewfg
Copy link
Contributor

Resolves #17558

Signed-off-by: AndrewFG software@whitebear.ch

@andrewfg andrewfg added enhancement An enhancement or new feature for an existing add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. work in progress A PR that is not yet ready to be merged labels Oct 16, 2024
@andrewfg andrewfg self-assigned this Oct 16, 2024
@andrewfg
Copy link
Contributor Author

andrewfg commented Oct 16, 2024 •
edited
Loading

@eengnr I have created this PR for you, but before we merge it it would be good if you can test and confirm that it functions as expected on your system.

The JAR file is in the zip file below. It will run on an OH v4.3 current milestone. You need to uninstall the stock binding, and drop the new Jar on your addons folder. It should add the new channel automatically, but if not you may need to delete and recreate your Things so that the new channel will be created.

org.openhab.binding.tado-4.3.0-SNAPSHOT.jar.zip

@andrewfg
[tado] add update indstructions
eb23194 
Signed-off-by: AndrewFG <software@whitebear.ch>
@andrewfg andrewfg mentioned this pull request Oct 18, 2024
Closed
@eengnr
Copy link

eengnr commented Oct 18, 2024

@eengnr I have created this PR for you, but before we merge it it would be good if you can test and confirm that it functions as expected on your system.

The JAR file is in the zip file below. It will run on an OH v4.3 current milestone. You need to uninstall the stock binding, and drop the new Jar on your addons folder. It should add the new channel automatically, but if not you may need to delete and recreate your Things so that the new channel will be created.

org.openhab.binding.tado-4.3.0-SNAPSHOT.jar.zip

Thanks for the snapshot! The time is available and updated in the linked item every 30 seconds.

But the newly created switch item linked to the channel stays OFF. But that's not a problem imho, I can just create a rule to turn it ON/OFF based in the time.

@andrewfg
Copy link
Contributor Author

the newly created switch item linked to the channel stays OFF

Understood. But that is not how OH core should be working. Let me think about it.

@jlaur jlaur changed the title [tado°] Add channel for remaining time of open window override [tado] Add channel for remaining time of open window override Oct 19, 2024
@andrewfg
Copy link
Contributor Author

@eengnr to properly link a Switch item to the openWindowRemainingTime channel, the item must be created with a "Hysteresis" Profile having a Lower Bound of <= 0 s (which maps to OFF) and an Upper Bound of >=1 s (which maps to ON)..

image

@andrewfg andrewfg removed additional testing preferred The change works for the pull request author. A test from someone else is preferred though. work in progress A PR that is not yet ready to be merged labels Oct 19, 2024
@andrewfg andrewfg requested a review from a team October 19, 2024 16:34
@eengnr
Copy link

eengnr commented Oct 19, 2024 •
edited
Loading

@andrewfg Ah thanks! I'll give it a try.

The German translation for the explanation of the lower/upper bound is missing the "or equal", but I set 0/1 now as in your screenshot.

Edit: with Hysteresis profile the switch item works 👍

lsiepel
lsiepel requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one comment. Otherwise LGTM

bundles/org.openhab.binding.tado/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
@andrewfg
[tado adopt reviewer suggestions
8448b76 
Signed-off-by: AndrewFG <software@whitebear.ch>
@andrewfg andrewfg requested a review from lsiepel October 21, 2024 21:47
lsiepel
lsiepel approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@lsiepel lsiepel merged commit 87023bd into openhab:main Oct 21, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Oct 21, 2024
@andrewfg andrewfg deleted the tado-open-window branch November 6, 2024 15:45
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
@andrewfg @KaaNee
[tado] Add channel for remaining time of open window override (openha…
e92a243 
…b#17576)

* [tado] Add open window override remaining time channel

Signed-off-by: AndrewFG <software@whitebear.ch>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
@andrewfg @matchews
[tado] Add channel for remaining time of open window override (openha…
00fa82d 
…b#17576)

* [tado] Add open window override remaining time channel

Signed-off-by: AndrewFG <software@whitebear.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

Assignees

@andrewfg andrewfg

Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[tado] openWindowDetected not available in API response
3 participants
@andrewfg @eengnr @lsiepel