Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ipcamera] Fix Reolink events do not auto restart #17581

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Conversation

Skinah
Copy link
Contributor

@Skinah Skinah commented Oct 17, 2024

Add recently added ability to auto re-start the ONVIF event streams to Reolink branded cameras.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah Skinah added the bug An unexpected problem or unintended behavior of an add-on label Oct 17, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment otherwise LGTM

@jlaur jlaur changed the title [ipcamera]Fix Reolink events do not auto restart. [ipcamera] Fix Reolink events do not auto restart Oct 18, 2024
…/binding/ipcamera/internal/handler/IpCameraHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@lsiepel lsiepel merged commit 1c649d8 into openhab:main Oct 19, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Oct 19, 2024
@Skinah Skinah deleted the ipcamera branch October 19, 2024 21:58
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
* Fix Reolink events do not auto restart.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
* Fix Reolink events do not auto restart.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
* Fix Reolink events do not auto restart.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants