[mqtt.homeassistant] Avoid improperly delivered triggers #17584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if multiple DeviceTrigger components share a topic, and each has a payload value configured, only messages matching that payload should be delivered to the corresponding channel Signed-off-by: Cody Cutrer <cody@cutrer.us>
lsiepel
changed the title
ccutrer
deleted the
mqtt-homeassistant-spurious-device_trigger-triggers
branch
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
if multiple DeviceTrigger components share a topic, and each has a payload value configured, only messages matching that payload should be delivered to the corresponding channel Signed-off-by: Cody Cutrer <cody@cutrer.us>
KaaNee
pushed a commit
to KaaNee/openhab-addons
that referenced
this pull request
Nov 8, 2024
if multiple DeviceTrigger components share a topic, and each has a payload value configured, only messages matching that payload should be delivered to the corresponding channel Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple DeviceTrigger components share a topic, and each has a payload value configured, only messages matching that payload should be delivered to the corresponding channel.
The DeviceTrigger already sets up the TextValue with the appropriate (single) enumeration of allowed value(s). But the mqtt.generic binding processes trigger before any value processing is done. So do the most basic of processing, to make sure the value is pertinent.