[lgwebos] Fix representation property #17588
Merged
+29
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel
added
the
enhancement
lsiepel
changed the title
lsiepel
added
rebuild
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel
commented
Oct 18, 2024
| @@ -494,6 +498,7 @@ public void onMessage(String message) { | |||
| map.put(PROPERTY_DEVICE_OS, jsonPayload.get("deviceOS").getAsString()); | |||
| map.put(PROPERTY_DEVICE_OS_VERSION, jsonPayload.get("deviceOSVersion").getAsString()); | |||
| map.put(PROPERTY_DEVICE_OS_RELEASE_VERSION, jsonPayload.get("deviceOSReleaseVersion").getAsString()); | |||
| map.put(PROPERTY_DEVICE_ID, jsonPayload.get("deviceUUID").getAsString()); | |||
There was a problem hiding this comment.
This is the deviceId / representationproperty fix, the rest of the changes are compiler/null annotation fixes.
KaaNee
pushed a commit
to KaaNee/openhab-addons
that referenced
this pull request
Nov 8, 2024
* Fix representation property * Null annotations and compiler fixes * Fix lowercase Signed-off-by: Leo Siepel <leosiepel@gmail.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Dec 16, 2024
* Fix representation property * Null annotations and compiler fixes * Fix lowercase Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the representation property
deviceIdis only set when the device is added by auto-discovery (managed thing). When the device is configured by a file based configuration the property is not set.This PR grabs this deviceId a.k.a UUID when performing the
helloprocedure similar to osVersion etc. This prevents the Thing to be added to the inbox while it already exists.Also fixes some null annotations and compiler warnings while at it.