Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ipcamera] Add support to change MJPEG source to a different RTSP sub stream to lower CPU usage #17591

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

Skinah
Copy link
Contributor

@Skinah Skinah commented Oct 20, 2024

Adds support to use a lower resolution RTSP feed as the mjpeg source which will lower CPU load on the openHAB server. Previously if you used a lower res feed, then any recordings made would use the lower res stream as well as the mjpeg feed.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah Skinah added the enhancement An enhancement or new feature for an existing add-on label Oct 20, 2024
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @lolodomo i'll let you merge this as you started the review.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit ed45e75 into openhab:main Oct 22, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Oct 22, 2024
@Skinah Skinah deleted the camera branch October 26, 2024 00:21
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
… stream to lower CPU usage (openhab#17591)

* Add support to change MJPEG sources to different RTSP sub streams

Signed-off-by: Matthew Skinner <matt@pcmus.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
… stream to lower CPU usage (openhab#17591)

* Add support to change MJPEG sources to different RTSP sub streams

Signed-off-by: Matthew Skinner <matt@pcmus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants