Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[emotiva] Improve logging, retry job, static typing and type inference. #17596

Merged
merged 1 commit into from
Oct 28, 2024
Merged

[emotiva] Improve logging, retry job, static typing and type inference. #17596

merged 1 commit into from
Oct 28, 2024

Conversation

espenaf
Copy link
Contributor

@espenaf espenaf commented Oct 20, 2024

  • Add and improve logging when trying to map channel change to Emotiva Control Commands.
  • Improve logging of notifications and keep-alive job.
  • Improve checking of retry job status.
  • Improve static typing of previous state.
  • Use type inference wherever possible.

@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Oct 21, 2024
lsiepel
lsiepel requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition, do have some questions and comments.

...binding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaCommandHelper.java Outdated Show resolved Hide resolved
...ding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaProcessorHandler.java Outdated Show resolved Hide resolved
...ding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaProcessorHandler.java Outdated Show resolved Hide resolved
...ding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaProcessorHandler.java Outdated Show resolved Hide resolved
...otiva/src/main/java/org/openhab/binding/emotiva/internal/protocol/EmotivaControlRequest.java Outdated Show resolved Hide resolved
@espenaf espenaf force-pushed the emotiva_improvements branch 4 times, most recently from f7a8d2e to 7dc7061 Compare October 24, 2024 18:11
lsiepel
lsiepel requested changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement. Just two comments about the logging and the non-existing channel remain.

@espenaf
[emotiva] Improve logging, retry job, static typing and type inference.
77f7c6c 
* Add and improve logging when trying to map channel change to Emotiva Control Commands.
* Improve logging of notifications and keep alive job.
* Improve checking of retry job status.
* Improve static typing of previous state.
* Use type inference in selected places.

Signed-off-by: Espen Fossen <espenaf@junta.no>
@espenaf espenaf force-pushed the emotiva_improvements branch from 063ddb4 to 77f7c6c Compare October 28, 2024 17:13
@espenaf
Copy link
Contributor Author

espenaf commented Oct 28, 2024

Thanks for this improvement. Just two comments about the logging and the non-existing channel remain.

Pushed the needed changes. So please have a look.

lsiepel
lsiepel approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the last comments. LGTM

@lsiepel lsiepel merged commit 025b96f into openhab:main Oct 28, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Oct 28, 2024
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
@espenaf @KaaNee
[emotiva] Improve logging, retry job, static typing and type inferenc…
93487a6 
…e. (openhab#17596)

* Add and improve logging when trying to map channel change to Emotiva Control Commands.
* Improve logging of notifications and keep alive job.
* Improve checking of retry job status.
* Improve static typing of previous state.
* Use type inference in selected places.

Signed-off-by: Espen Fossen <espenaf@junta.no>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
@espenaf @matchews
[emotiva] Improve logging, retry job, static typing and type inferenc…
40a8b41 
…e. (openhab#17596)

* Add and improve logging when trying to map channel change to Emotiva Control Commands.
* Improve logging of notifications and keep alive job.
* Improve checking of retry job status.
* Improve static typing of previous state.
* Use type inference in selected places.

Signed-off-by: Espen Fossen <espenaf@junta.no>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
@espenaf
[emotiva] Improve logging, retry job, static typing and type inferenc…
29cca2c 
…e. (openhab#17596)

* Add and improve logging when trying to map channel change to Emotiva Control Commands.
* Improve logging of notifications and keep alive job.
* Improve checking of retry job status.
* Improve static typing of previous state.
* Use type inference in selected places.

Signed-off-by: Espen Fossen <espenaf@junta.no>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur left review comments

@lsiepel lsiepel lsiepel approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@espenaf @lsiepel @jlaur