Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt.homeassistant] Add support for Event component #17599

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Oct 21, 2024

No description provided.

@ccutrer ccutrer requested a review from antroids as a code owner October 21, 2024 01:01
@ccutrer ccutrer force-pushed the mqtt-homeassistant-event branch 2 times, most recently from d9b44bd to 23d9a79 Compare October 21, 2024 01:06
@ccutrer ccutrer marked this pull request as draft October 21, 2024 01:13
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Oct 21, 2024
@ccutrer ccutrer force-pushed the mqtt-homeassistant-event branch 2 times, most recently from ebc563c to 284c538 Compare October 21, 2024 19:18
@ccutrer ccutrer marked this pull request as ready for review October 21, 2024 19:34
@ccutrer ccutrer requested a review from lsiepel October 21, 2024 19:34
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the conflict, otherwise LGTM

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer force-pushed the mqtt-homeassistant-event branch from 80d8c1c to 54a6f0d Compare October 21, 2024 20:39
@ccutrer
Copy link
Contributor Author

ccutrer commented Oct 21, 2024

Sorry for the rebase/squash. At first I thought I was doing the merge resolution wrong, cause specs were failing, until I realized that this commit found a bug in the event trigger commit (which wasn't there when I was developing this PR).

@lsiepel lsiepel merged commit eac49a8 into openhab:main Oct 21, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Oct 21, 2024
@ccutrer ccutrer deleted the mqtt-homeassistant-event branch October 21, 2024 20:50
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants