-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shelly] Add totalKWH channels for Shelly Pro 3EM #17602
Conversation
Signed-off-by: Jonathan van de Giessen <jonathan.vandegiessen@student.hu.nl>
Signed-off-by: Jonathan van de Giessen <jonathan.vandegiessen@student.hu.nl>
@jlaur To be honest, it's a bug fix and an enchancement at the same time. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, otherwise LGTM
Channels do not seem to be created dynamically, so this would also require thing upgrade instructions.
For future PR's it would be nice to seperate the bug fix and the enhancement. This would make it possible to 1. easy backport bug fixes and 2. list the changes/fixes speerately in the release notes.
bundles/org.openhab.binding.shelly/src/main/resources/OH-INF/i18n/shelly_de.properties
Outdated
Show resolved
Hide resolved
The I don't mind to creating an extra pull request, so would you prefer I make a new one? |
Signed-off-by: Jonathan van de Giessen <jonathan.vandegiessen@student.hu.nl>
Signed-off-by: Jonathan van de Giessen <jonathan.vandegiessen@student.hu.nl>
* added totalkwh channel Signed-off-by: Jonathan van de Giessen <jonathan.vandegiessen@student.hu.nl>
* added totalkwh channel Signed-off-by: Jonathan van de Giessen <jonathan.vandegiessen@student.hu.nl>
Added totalKWH channels for Shelly Pro 3EM
Description
I added the missing
totalKWH
channels for the Shelly Pro 3EM, see #16772. There is also a newtotalKWH
channel created for the entire device. The channels forreactivewatts
are left untouched because I couldn't locate the associated data.After linking items to the
totalKWH
channels I noticed that the values only update when you restart OpenHAB at least once.This also happens for other channels so it's not related to this pull request.
I am btw not really familiar with the code so there are probably some improvements.