Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsscripting] Remove workaround for multi-threading issues with UI-based scripts #17630

Merged
merged 1 commit into from
Oct 26, 2024
Merged

[jsscripting] Remove workaround for multi-threading issues with UI-based scripts #17630

merged 1 commit into from
Oct 26, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Oct 26, 2024 •
edited by lsiepel
Loading

Follow-up for #17510.
Depends on openhab/openhab-core#4426.

@florian-h05
[jsscripting] Remove Thread.sleep workaround for multi-threading issu…
554495b 
…es with UI-based scripts

Follow-up for openhab#1710.
Depends on openhab/openhab-core#4426.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05 florian-h05 mentioned this pull request Oct 26, 2024
Merged
@lsiepel lsiepel added the awaiting other PR Depends on another PR label Oct 26, 2024
@lsiepel lsiepel requested a review from a team October 26, 2024 12:12
@kaikreuzer kaikreuzer removed the awaiting other PR Depends on another PR label Oct 26, 2024
kaikreuzer
kaikreuzer approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice that the workaround can be removed that quickly again. :-)

@kaikreuzer kaikreuzer merged commit abe8199 into openhab:main Oct 26, 2024
4 of 5 checks passed
@kaikreuzer kaikreuzer added this to the 4.3 milestone Oct 26, 2024
@florian-h05 florian-h05 deleted the jsscripting branch October 26, 2024 21:43
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
@florian-h05 @KaaNee
[jsscripting] Remove Thread.sleep workaround for multi-threading issu…
86ca951 
…es with UI-based scripts (openhab#17630)

Follow-up for openhab#1710.
Depends on openhab/openhab-core#4426.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
@florian-h05 @matchews
[jsscripting] Remove Thread.sleep workaround for multi-threading issu…
d8b23e9 
…es with UI-based scripts (openhab#17630)

Follow-up for openhab#1710.
Depends on openhab/openhab-core#4426.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@florian-h05 @kaikreuzer @lsiepel