[evcc] Fix charge plan time channel not using correct timezone #17640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laith-Budairi
force-pushed
the
evcc-17620
branch
from
377ff72 to
3abbfd1
Compare
…#17620) Signed-off-by: Laith Budairi <laith.budairi@exalt.ps>
Laith-Budairi
force-pushed
the
evcc-17620
branch
from
3abbfd1 to
34f5b27
Compare
florian-h05
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Code LGTM, thanks!
I don‘t use the binding anymore, so would be good if someone in #17620 could verify the fix.
florian-h05
changed the title
Tested it out with the issue owner, the fix seems to be working fine |
lsiepel
added
the
enhancement
lsiepel
changed the title
jlaur
added
bug
jlaur
reviewed
Oct 28, 2024
| + planTime.toLocalDateTime().format(DateTimeFormatter.ISO_LOCAL_DATE_TIME) + "Z", "POST"); | ||
| ZoneId zoneId = timeZoneProvider.getTimeZone(); | ||
| ZonedDateTime adjustedTime = planTime.withZoneSameInstant(zoneId); | ||
| String formattedTime = adjustedTime.format(DateTimeFormatter.ISO_OFFSET_DATE_TIME); |
There was a problem hiding this comment.
@Laith-Budairi - out of curiosity, does the API support UTC time, e.g. 2024-10-24T05:30:00.636Z? In this case, the fix could be as simple as:
String formattedTime = planTime.toInstant().toString();And there would be no need to use TimeZoneProvider.
KaaNee
pushed a commit
to KaaNee/openhab-addons
that referenced
this pull request
Nov 8, 2024
…#17620) (openhab#17640) Signed-off-by: Laith Budairi <laith.budairi@exalt.ps>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Dec 16, 2024
…#17620) (openhab#17640) Signed-off-by: Laith Budairi <laith.budairi@exalt.ps>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
…#17620) (openhab#17640) Signed-off-by: Laith Budairi <laith.budairi@exalt.ps> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17620.
this change fixes the Charge Plan Time not showing correctly on EVCC.
jar file with fix: EVCC jar
Signed-off-by: Laith Budairi laith38@yahoo.com