Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netatmo] Webhook events are dispatched but group id is missing #17661

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

clinique
Copy link
Contributor

Resolves issue #17660

Being the first opening this issue, I guess this feature is not that much used :-)

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique clinique added the bug An unexpected problem or unintended behavior of an add-on label Oct 29, 2024
@clinique clinique self-assigned this Oct 29, 2024
@clinique clinique requested a review from lolodomo as a code owner October 29, 2024 14:08
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One textual comment is open, otherwise LGTM.
Would be nice if @lolodomo can confim.

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@lsiepel lsiepel merged commit 51be3b2 into openhab:main Nov 6, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Nov 6, 2024
@clinique clinique deleted the netatmo_17660_webhook branch November 6, 2024 08:30
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
…hab#17661)

* Events were dispatched but group id was missing

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
…hab#17661)

* Events were dispatched but group id was missing

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants