Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] Consider setpoint duration when manual changing the setpoint temperature #17662

Merged
merged 3 commits into from
Nov 6, 2024
Merged

[netatmo] Consider setpoint duration when manual changing the setpoint temperature #17662

merged 3 commits into from
Nov 6, 2024

Conversation

clinique
Copy link
Contributor

Resolves issue #17652.

@clinique
setpointDefaultDuration was not always considered
4f97ca8 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Correcting error message
81fae39 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique clinique requested a review from lolodomo as a code owner October 29, 2024 15:31
@clinique
Correcting tabs
fc98f43 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Copy link
Contributor Author

clinique commented Oct 29, 2024 •
edited
Loading

There is no API to update the setpoint-duration, so I clarified the fact that this is read-only.
Enabled the actualization of the setpoint-duration when updated from the Netatmo App.

Due to the firstlaunch test, it happened (depending upon initialization order of things) that the value was not catched.

@nelsonaponte
Copy link

nelsonaponte commented Oct 29, 2024 •
edited
Loading

@clinique, can this also be ported back to 4.2.X?

@clinique
Copy link
Contributor Author

@clinique, can this also be ported back to 4.2.X?

Yes, it can.

@clinique clinique self-assigned this Oct 30, 2024
lsiepel
lsiepel approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Would be nice if @lolodomo can confirm

@lsiepel lsiepel merged commit 41c8c45 into openhab:main Nov 6, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Nov 6, 2024
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Nov 6, 2024
@clinique clinique deleted the netatmo_17652 branch November 6, 2024 08:30
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
@clinique @KaaNee
[netatmo] Consider setpoint duration when manual changing the setpoin…
b2fa001 
…t temperature (openhab#17662)

* setpointDefaultDuration was not always considered

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
@clinique @matchews
[netatmo] Consider setpoint duration when manual changing the setpoin…
3d8f61e 
…t temperature (openhab#17662)

* setpointDefaultDuration was not always considered

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
@clinique
[netatmo] Consider setpoint duration when manual changing the setpoin…
3ae0e63 
…t temperature (openhab#17662)

* setpointDefaultDuration was not always considered

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

Assignees

@clinique clinique

Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@clinique @nelsonaponte @lsiepel