[fmiweather] Fix discovery exception

[jlaur]

Fixes #17668
Refactoring similar to #17616

[ssalonen]

Thanks, looks reasonable to me!

[lsiepel]

Thanks,LGTM

I need coffee, missed the test label. If there is a regression ping me and I’ll look at it with high priority

[jlaur]

I need coffee, missed the test label. If there is a regression ping me and I’ll look at it with high priority

No worries, I needed glasses when looking for the "Convert to draft" in the GitHub app for Android. 😄 I just remembered that I wanted to have a look at possibly refactoring this, so that it wouldn't perform network call from the constructor, but rather when scan (manual or background) is triggered:

openhab-addons/bundles/org.openhab.binding.fmiweather/src/main/java/org/openhab/binding/fmiweather/internal/discovery/FMIWeatherDiscoveryService.java

Lines 78 to 90 in 276254d

	/**
	* Creates a {@link FMIWeatherDiscoveryService} with immediately enabled background discovery.
	*/
	@Activate
	public FMIWeatherDiscoveryService(final @Reference LocationProvider locationProvider,
	final @Reference HttpClientFactory httpClientFactory) {
	super(SUPPORTED_THING_TYPES, DISCOVER_TIMEOUT_SECONDS, true);
	this.locationProvider = locationProvider;
	httpClient = httpClientFactory.getCommonHttpClient();
	stationsCache = new ExpiringCache<>(STATIONS_CACHE_MILLIS, () -> {
	try {
	return new Client(httpClient).queryWeatherStations(STATIONS_TIMEOUT_MILLIS);

I tested the forecast Thing, but not the observation Thing since I don't have such a weather station. @ssalonen - just to be sure, do you think you'd be able to test this?

[ssalonen]

I am a bit short on time to test this out

it should discover observation stations nearby your location

so if you put helsinki's coordinates in openhab, you should see something popping up

[jlaur]

it should discover observation stations nearby your location

so if you put helsinki's coordinates in openhab, you should see something popping up

Thanks, it works nicely! 👍