Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binding name in first README lines #17675

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Oct 30, 2024

I found some irregularities in the list of addons, for example:

image
image
image

The only thing I could find within these bindings being different from other bindings was the first heading in the README not ending in "Binding" (case sensitive):

$ find ./bundles/org.openhab.binding.* -maxdepth 1 -type f -name "README.md" -exec sh -c 'head -n 1 "$1" | grep -P -qv "Binding\r?$" && echo "$1"' _ {} \;
./bundles/org.openhab.binding.bluetooth.airthings/README.md
./bundles/org.openhab.binding.bluetooth.am43/README.md
./bundles/org.openhab.binding.bluetooth.bluegiga/README.md
./bundles/org.openhab.binding.bluetooth.bluez/README.md
./bundles/org.openhab.binding.bluetooth.blukii/README.md
./bundles/org.openhab.binding.bluetooth.daikinmadoka/README.md
./bundles/org.openhab.binding.bluetooth.generic/README.md
./bundles/org.openhab.binding.bluetooth.govee/README.md
./bundles/org.openhab.binding.bluetooth.hdpowerview/README.md
./bundles/org.openhab.binding.bluetooth.radoneye/README.md
./bundles/org.openhab.binding.bluetooth.roaming/README.md
./bundles/org.openhab.binding.bluetooth.ruuvitag/README.md
./bundles/org.openhab.binding.freeathome/README.md
./bundles/org.openhab.binding.lgtvserial/README.md
./bundles/org.openhab.binding.modbus.e3dc/README.md
./bundles/org.openhab.binding.modbus.helioseasycontrols/README.md
./bundles/org.openhab.binding.modbus.stiebeleltron/README.md
./bundles/org.openhab.binding.modbus.studer/README.md
./bundles/org.openhab.binding.modbus.sunspec/README.md
./bundles/org.openhab.binding.paradoxalarm/README.md
./bundles/org.openhab.binding.pentair/README.md
./bundles/org.openhab.binding.velux/README.md

Therefore I have fixed these headings to be consistent with others.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Velux LGTM

@jsjames
Copy link
Contributor

jsjames commented Oct 30, 2024

LGTM

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit ed93eb5 into openhab:main Oct 30, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Oct 30, 2024
@jlaur jlaur deleted the readme-binding-name branch November 4, 2024 21:08
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants