Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugwiseha] Improve connection stability #17677

Merged
merged 6 commits into from
Nov 17, 2024
Merged

[plugwiseha] Improve connection stability #17677

merged 6 commits into from
Nov 17, 2024

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Oct 30, 2024 •
edited
Loading

This PR mainly improves the handling of the connection to the Adam device, but also has other improvements:

  • Whenever a timeout occurs, a 3 second delay is added to give the device some time to catch up.
  • Improved locking to prevent multiple parallel calls to the device
  • When a zone temperature set command is performed it now also accepts a DecimalType.
  • Various minor fixes like javadoc, method modifiers and others.
  • Solve compile warnings
  • Adjust refresh interval to match both config and readme

@lsiepel
Improvements
f46acf2 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Fix compile warnings
3f78023 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Oct 30, 2024
@lsiepel lsiepel requested a review from a team October 30, 2024 22:03
@lsiepel lsiepel marked this pull request as draft October 30, 2024 22:40
@lsiepel
Sync config with readme
b7dd4fc 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Fix unit detection
9a9e26b 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel marked this pull request as ready for review October 31, 2024 13:55
@lsiepel
Some more adjustments
0dab7f5 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Fix NPE
d0da141 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lolodomo
lolodomo approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 4a5aa04 into openhab:main Nov 17, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Nov 17, 2024
@lsiepel lsiepel deleted the plugwiseha-improvements branch November 17, 2024 10:36
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
@lsiepel @matchews
[plugwiseha] Improve connection stability (openhab#17677)
eabcd2d 
* Improvements
* Sync config with readme
* Fix unit detection
* Fix NPE

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@lsiepel @lolodomo