-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[miio] Add support for Smart Air Purifier 4 Lite zhimi.airp.rmb1 #17680
Conversation
Adding support for the following models: * Xiaomi Smart Air Purifier 4 Lite (modelId: zhimi.airp.rmb1) Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
@@ -13048,6 +13098,7 @@ Number lp_autooff_delay "Low Power Limit Time" (G_powerstrip) {channel="miio:bas | |||
Number lp_threshold "Low Power Threshold" (G_powerstrip) {channel="miio:basic:powerstrip:lp_threshold"} | |||
``` | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought we fixed creation of this excess whiteline
@marcelrv where are we with this PR? As you marked it WIP, i guess it still needs some work? |
No, not really. I was hoping for some more feedback from the tester, but I think we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
…nhab#17680) * [miio] add support for Smart Air Purifier 4 Lite zhimi.airp.rmb1 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
…nhab#17680) * [miio] add support for Smart Air Purifier 4 Lite zhimi.airp.rmb1 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
…nhab#17680) * [miio] add support for Smart Air Purifier 4 Lite zhimi.airp.rmb1 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Updating the device list to the latest device list and adding support for the following model:
closes #17572