Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] Add support for Smart Air Purifier 4 Lite zhimi.airp.rmb1 #17680

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

marcelrv
Copy link
Contributor

Updating the device list to the latest device list and adding support for the following model:

  • Xiaomi Smart Air Purifier 4 Lite (modelId: zhimi.airp.rmb1)

closes #17572

Adding support for the following models:
* Xiaomi Smart Air Purifier 4 Lite (modelId: zhimi.airp.rmb1)

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv added the work in progress A PR that is not yet ready to be merged label Oct 31, 2024
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@@ -13048,6 +13098,7 @@ Number lp_autooff_delay "Low Power Limit Time" (G_powerstrip) {channel="miio:bas
Number lp_threshold "Low Power Threshold" (G_powerstrip) {channel="miio:basic:powerstrip:lp_threshold"}
```


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought we fixed creation of this excess whiteline

@lsiepel lsiepel marked this pull request as draft November 1, 2024 11:42
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Nov 1, 2024
@lsiepel lsiepel changed the title [miio] add support for Smart Air Purifier 4 Lite zhimi.airp.rmb1 [miio] Add support for Smart Air Purifier 4 Lite zhimi.airp.rmb1 Nov 1, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Dec 11, 2024

@marcelrv where are we with this PR? As you marked it WIP, i guess it still needs some work?

@marcelrv marcelrv removed the work in progress A PR that is not yet ready to be merged label Dec 12, 2024
@marcelrv
Copy link
Contributor Author

@marcelrv where are we with this PR? As you marked it WIP, i guess it still needs some work?

No, not really. I was hoping for some more feedback from the tester, but I think we can merge.

@lsiepel lsiepel marked this pull request as ready for review December 21, 2024 23:51
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 62cdb14 into openhab:main Dec 21, 2024
4 of 5 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Dec 21, 2024
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
…nhab#17680)

* [miio] add support for Smart Air Purifier 4 Lite zhimi.airp.rmb1

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
DrRSatzteil pushed a commit to DrRSatzteil/openhab-addons that referenced this pull request Jan 3, 2025
…nhab#17680)

* [miio] add support for Smart Air Purifier 4 Lite zhimi.airp.rmb1

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
chilobo pushed a commit to chilobo/openhab-addons that referenced this pull request Feb 10, 2025
…nhab#17680)

* [miio] add support for Smart Air Purifier 4 Lite zhimi.airp.rmb1

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[miio] Add support for Xiaomi Smart Air Purifier 4 Lite (zhimi.airp.rmb1)
2 participants