Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ism8] Add channel types for heat pumps #17688

Merged
merged 5 commits into from
Nov 5, 2024
Merged

[ism8] Add channel types for heat pumps #17688

merged 5 commits into from
Nov 5, 2024

Conversation

holgerfriedrich
Copy link
Member

@holgerfriedrich holgerfriedrich commented Nov 2, 2024 •
edited
Loading

Extend add-on to support new information provided by lates ISM firmware versions 1.80 and 1.90.

  • Add channel type power-r used by CHA device
  • Add channel type active-energy-r used by solar module
  • Add channel type number-r used for device information
  • Extend channel type volumetricflow-r to data type used by solar module
  • i18n
  • Rework documentation

Refs: #17682

@holgerfriedrich
[ism8] Add channel types for heat pumps
2a7391b 
Extend add-on to support new information provided by lates ISM firmware
versions 1.80 and 1.90.

* Add channel type power-r used by CHA device
* Add channel type activeenergy-r used by solar module
* Add channel type value1ucount-r and value2ucount-r used for device
  information
* Extend channel type volumetricflow-r to data type used by solar module
* i18n
* Rework documentation

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich added enhancement An enhancement or new feature for an existing add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Nov 2, 2024
@holgerfriedrich
Copy link
Member Author

Tests to be extended.

Live test on ISM8 not yet done. I can do some testing of the new channels next week.

lsiepel
lsiepel requested changes Nov 2, 2024
View reviewed changes
bundles/org.openhab.binding.ism8/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ism8/README.md Outdated Show resolved Hide resolved
@holgerfriedrich
reviewer suggestions
3a0da57 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich
reviewer suggestions
12ffae2 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich
Add tests, fix implementation
89d8aca 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich
Copy link
Member Author

Tests have now been added and cover reading all implemented read data points.

Live test on ISM8 not yet done. I can do some testing of the new channels next week.

@holgerfriedrich
Mark channel number-r readonly
e8ba5d1 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
lsiepel
lsiepel approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM. Will wait for live test to be confirmed.

@holgerfriedrich
Copy link
Member Author

@lsiepel Thank you. I think we can proceed, I tested successfully on live system.
CHA data (power channels) work fine. Device info works as well.

I could not test the new channels for solar module, as the system under test did not provide related datapoints.

@lsiepel
Copy link
Contributor

lsiepel commented Nov 5, 2024

@lsiepel Thank you. I think we can proceed, I tested successfully on live system. CHA data (power channels) work fine. Device info works as well.

I could not test the new channels for solar module, as the system under test did not provide related datapoints.

Risk is minimal, let’s go

@lsiepel lsiepel merged commit d40ecd3 into openhab:main Nov 5, 2024
5 checks passed
@lsiepel lsiepel removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Nov 5, 2024
@lsiepel lsiepel added this to the 4.3 milestone Nov 5, 2024
@holgerfriedrich holgerfriedrich mentioned this pull request Nov 5, 2024
Merged
@holgerfriedrich holgerfriedrich deleted the pr-ism8 branch November 5, 2024 23:16
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
@holgerfriedrich @KaaNee
[ism8] Add channel types for heat pumps (openhab#17688)
4e9df7b 
* [ism8] Add channel types for heat pumps

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich mentioned this pull request Nov 11, 2024
Merged
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
@holgerfriedrich @matchews
[ism8] Add channel types for heat pumps (openhab#17688)
18523b2 
* [ism8] Add channel types for heat pumps

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@holgerfriedrich @lsiepel