Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shelly] Add support for Shelly Plus RGBW PM #17692

Merged
merged 3 commits into from
Nov 10, 2024
Merged

[shelly] Add support for Shelly Plus RGBW PM #17692

merged 3 commits into from
Nov 10, 2024

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Nov 3, 2024

Closes #16405

@J-N-K J-N-K added the enhancement An enhancement or new feature for an existing add-on label Nov 3, 2024
@J-N-K J-N-K marked this pull request as ready for review November 7, 2024 08:26
@J-N-K J-N-K requested a review from markus7017 as a code owner November 7, 2024 08:26
@lsiepel
Copy link
Contributor

lsiepel commented Nov 10, 2024

Can you add this new thing to the README.md and fix the conflict?

J-N-K added 3 commits November 10, 2024 17:26
@J-N-K
[shelly] Add support for Shelly Plus RGBW PM
ab5d2dd 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
fix test
d3a9906 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
fixes
8ee6abc 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Copy link
Member Author

J-N-K commented Nov 10, 2024

Done

lsiepel
lsiepel approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@lsiepel lsiepel merged commit a32ac52 into openhab:main Nov 10, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Nov 10, 2024
@J-N-K J-N-K deleted the shellyrgbwpm branch November 10, 2024 18:44
@chrostek
Copy link

chrostek commented Dec 8, 2024

does not work if the shelly is in "Device Profile" = "Lights x 4" instead of "RGB(W)".
Error in OH: "Es trat ein unerwartetes Problem beim API-Zugriff auf. Überprüfen Sie die Logdatei für genauere Informationen."
Error in Shelly Debug Console: "shos_rpc_inst.c:223 No handler for RGBW.GetStatus"

@lsiepel
Copy link
Contributor

lsiepel commented Dec 8, 2024

does not work if the shelly is in "Device Profile" = "Lights x 4" instead of "RGB(W)". Error in OH: "Es trat ein unerwartetes Problem beim API-Zugriff auf. Überprüfen Sie die Logdatei für genauere Informationen." Error in Shelly Debug Console: "shos_rpc_inst.c:223 No handler for RGBW.GetStatus"

Please open a new issue with all details you have.

matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
@J-N-K @matchews
[shelly] Add support for Shelly Plus RGBW PM (openhab#17692)
ab18516 
* [shelly] Add support for Shelly Plus RGBW PM

Signed-off-by: Jan N. Klug <github@klug.nrw>
@darkspirit510 darkspirit510 mentioned this pull request Dec 30, 2024
Open
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
@J-N-K
[shelly] Add support for Shelly Plus RGBW PM (openhab#17692)
268eabd 
* [shelly] Add support for Shelly Plus RGBW PM

Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@markus7017 markus7017 Awaiting requested review from markus7017 markus7017 is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[shelly] Support for Plus RGBW PM
3 participants
@J-N-K @lsiepel @chrostek