Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[knx] Improve handling of unknown encrypted frames #17721

Merged
merged 1 commit into from
Nov 10, 2024
Merged

[knx] Improve handling of unknown encrypted frames #17721

merged 1 commit into from
Nov 10, 2024

Conversation

holgerfriedrich
Copy link
Member

  • Show encrypted frames without a matching key using console command "openhab:knx list-unknown-ga"; sort output numerically by GA.
  • Add trace logging to show decryption error due to missing key. Previously, those frames were silently dropped unless logging for Calimero was explicitly enabled as well.

@holgerfriedrich
[knx] Improve handling of unknown encrypted frames
4a19d46 
* Show encrypted frames without a matching key using console command
  "openhab:knx list-unknown-ga"; sort output numerically by GA.
* Add trace logging to show decryption error due to missing key.
  Previously, those frames were silently dropped unless logging for
  Calimero was explicitly enabled as well.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
lsiepel
lsiepel approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 10b3f0a into openhab:main Nov 10, 2024
5 checks passed
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Nov 10, 2024
@lsiepel lsiepel added this to the 4.3 milestone Nov 10, 2024
@holgerfriedrich holgerfriedrich deleted the pr-knx-decrypt-log branch November 10, 2024 21:52
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
@holgerfriedrich @matchews
[knx] Improve handling of unknown encrypted frames (openhab#17721)
acbbaff 
* Show encrypted frames without a matching key using console command
  "openhab:knx list-unknown-ga"; sort output numerically by GA.
* Add trace logging to show decryption error due to missing key.
  Previously, those frames were silently dropped unless logging for
  Calimero was explicitly enabled as well.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@holgerfriedrich @lsiepel