Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[solax] Fix the parsing of total consumption channel X3-Hybrid-G4 #17726

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

theater
Copy link
Contributor

@theater theater commented Nov 10, 2024

Very small change in the parser of the total consumption channel. It seems it was divided wrong.
According to the users instead of /10 must be /100.

Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
@theater theater added the bug An unexpected problem or unintended behavior of an add-on label Nov 10, 2024
@theater theater changed the title [solax] Fix the parsing of total consumption channel [solax] Fix the parsing of total consumption channel X3-Hybrid-G4 Nov 10, 2024
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/solax-binding/146326/228

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 288b80f into openhab:main Nov 10, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Nov 10, 2024
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on community approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants