Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ipobserver] Add channel rainTotal #17727

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Nov 10, 2024

Fixes: #17658

  • Add channel rainTotal

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Nov 10, 2024
@lsiepel lsiepel marked this pull request as ready for review November 11, 2024 18:56
@lsiepel lsiepel requested a review from Skinah as a code owner November 11, 2024 18:56
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 22aeffb into openhab:main Nov 16, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Nov 16, 2024
@lsiepel lsiepel deleted the ipobserver-rain branch November 16, 2024 14:28
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
* Add totalRain channel

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IpObserver] Yearly Raining WS3500 Weather Station
2 participants