Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meteofrance] Documentation enhancements and more #17740

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

clinique
Copy link
Contributor

Latitude and longitude where incorrectly formatted.
Documentation update
First rain forecast used as current value

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique clinique added bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on labels Nov 12, 2024
@clinique clinique self-assigned this Nov 12, 2024
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@lsiepel lsiepel removed the enhancement An enhancement or new feature for an existing add-on label Nov 12, 2024
@clinique clinique requested a review from lsiepel November 20, 2024 16:35
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, otherwise LGTM

bundles/org.openhab.binding.meteofrance/README.md Outdated Show resolved Hide resolved
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel merged commit 91f16fa into openhab:main Nov 20, 2024
4 of 5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Nov 20, 2024
@clinique clinique deleted the meteofrance_improvements branch November 20, 2024 22:44
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
* Some binding enhancements

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants