[mercedesme] Websocket decoupling #17753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
weymann
changed the title
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
weymann
changed the title
lsiepel
added
the
enhancement
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
lsiepel
requested changes
Nov 20, 2024
...mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/handler/AccountHandler.java
Outdated
Show resolved
Hide resolved
...mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/handler/VehicleHandler.java
Outdated
Show resolved
Hide resolved
...ing.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/server/MBWebsocket.java
Outdated
Show resolved
Hide resolved
|
Got some negative feedback which I still want to investigate. Please wait with merging! |
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
|
@lsiepel PR can be merged. |
lsiepel
approved these changes
Dec 1, 2024
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Dec 16, 2024
* decouple websocket thread from handler update Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
* decouple websocket thread from handler update Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings from MercedesMe websocket reported in community, After analysis design flaw in current binding needs to solved:
Websocket thread is performing the complete chain from reading bytestream up to channel updates. While this other messages are dismissed
Structural change to free websocket thread as early as possible: