Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[verisure] Fix broken cloud authentication #17761

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

jannegpriv
Copy link
Contributor

Fix for Verisure bridge cannot login (#17730).

Re-wrote logic for login and handling of tokens.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Nov 18, 2024
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a added some quick feedback from first read-through.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
@jlaur jlaur linked an issue Nov 20, 2024 that may be closed by this pull request
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment with a few clarifications needed, otherwise LGTM.

@jlaur jlaur changed the title [verisure] Fix for Verisure bridge cannot login (#17730) [verisure] Fix broken cloud authentication Nov 21, 2024
@jlaur
Copy link
Contributor

jlaur commented Nov 21, 2024

@jannegpriv - I assume this issue prevents the binding from working at all, is that correct?

@jannegpriv
Copy link
Contributor Author

jannegpriv commented Nov 21, 2024 via email

@jlaur jlaur added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Nov 22, 2024
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit a9a02af into openhab:main Nov 22, 2024
4 of 5 checks passed
@jlaur jlaur added this to the 4.3 milestone Nov 22, 2024
jlaur pushed a commit that referenced this pull request Nov 22, 2024
* Fix Verisure bridge cannot login (#17730)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Nov 22, 2024
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/verisure-returns-exception-error/159611/4

matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
* Fix Verisure bridge cannot login (openhab#17730)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[verisure] Bridge cannot login
4 participants